FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Remove upper bound on dask dependency by oliverholworthy · Pull Request #3343 · feast-dev/feast · GitHub

/ feast Public

chore: Remove upper bound on dask dependency - #3343

Merged
kevjumba merged 1 commit into
feast-dev:masterfrom
oliverholworthy:dask-requirement-remove-upper-bound
Nov 28, 2022
ConversationCommits (1)ChecksFiles changed
Merged

chore: Remove upper bound on dask dependency#3343
kevjumba merged 1 commit into
feast-dev:masterfrom
oliverholworthy:dask-requirement-remove-upper-bound

Conversation

oliverholworthy commented Nov 9, 2022

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Motivation: Being able to use feast in an application with more recent versions of dask in a Python 3.8+ environment without having to work around conflicts due to versions specified in package.

This PR removes the upper bound on dask requirement added in #2342 This upper bound was added because newer versions of dask dropped support for Python 3.7.

However, the upper bound isn't necesesary for Python 3.7 compatibility (unless a version of dask was released that had the wrong python_requires specified.)

  • pip install dask (or "dask>=2021.*") in a Python 3.7 environment installs dask==2022.2.0 which was the last version that specfied comaptitibility with Python 3.7 (with python_requires in the pacakge config)

Additional context

It seems that in practice feast has dropped support for Python 3.7:

Remove upper bound on dask dependency
159ed80 
Signed-off-by: Oliver Holworthy <oholworthy@nvidia.com>

beauchbum commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Just bumped into this conflict today when trying to add feast as a dependency in our model-training repo. Thanks for opening a PR to address this.

codecov-commenter commented Nov 14, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (5c9b6fe) to head (159ed80).
⚠️ Report is 1552 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
+ Coverage   67.65%   76.73%   +9.07%     
==========================================
  Files         181      218      +37     
  Lines       16645    18466    +1821     
==========================================
+ Hits        11262    14170    +2908     
+ Misses       5383     4296    -1087
Flag Coverage Δ
integrationtests 67.48% <ø> (-0.18%) ⬇️
unittests 57.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

achals commented Nov 14, 2022

Copy link
Copy Markdown
Member

/ok-to-test

feast-ci-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, oliverholworthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

achals added the lgtm label Nov 28, 2022
kevjumba merged commit 2733368 into feast-dev:master Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

achals achals approved these changes

Assignees

No one assigned

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL