chore: Clean up makefile - #4799
Merged
franciscojavierarceo merged 5 commits intoDec 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
emgeee
force-pushed
the
matt/clean-makefile
branch
from
c23deaa to
78fa4ab
Compare
November 28, 2024 01:33
Comment thread
Makefile
Comment thread
Makefile
Comment thread
Makefile
Comment thread
Makefile
Comment thread
docs/project/development-guide.md
franciscojavierarceo
approved these changes
Nov 28, 2024
franciscojavierarceo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
this lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like pytest failed because it's not installed in the dependencies. May have to add that to the action. |
Sorry, something went wrong.
Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
dmartinol
approved these changes
Nov 28, 2024
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
Dec 3, 2024
* clean up dependency installation makefile tasks Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * rewrite lock-python-dependencies-all to be more DRY Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update environment setup docs Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update smoke test Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * small change Signed-off-by: Matt Green <emgeee@users.noreply.github.com> --------- Signed-off-by: Matt Green <emgeee@users.noreply.github.com> Signed-off-by: Theodor Mihalache <tmihalac@redhat.com>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Dec 5, 2024
* clean up dependency installation makefile tasks Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * rewrite lock-python-dependencies-all to be more DRY Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update environment setup docs Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update smoke test Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * small change Signed-off-by: Matt Green <emgeee@users.noreply.github.com> --------- Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
dharmisha
pushed a commit
to nishantgaurav-dev/feast
that referenced
this pull request
Jan 15, 2025
* clean up dependency installation makefile tasks Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * rewrite lock-python-dependencies-all to be more DRY Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update environment setup docs Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * update smoke test Signed-off-by: Matt Green <emgeee@users.noreply.github.com> * small change Signed-off-by: Matt Green <emgeee@users.noreply.github.com> --------- Signed-off-by: Matt Green <emgeee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current guide for setting up a development environment is unclear and the existing makefile includes multiple tasks that do very similar things, are un-used, or are confusingly named. This PR seeks to clear up confusion around how one should configure their python environment for developing feast.
This PR
Which issue(s) this PR fixes:
Misc