feat: Adding Click command to display configuration details - #5036
Merged
redhatHameed merged 2 commits intoFeb 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: ShaktidharK1997 <shaktidhark.1997@gmail.com>
franciscojavierarceo
approved these changes
Feb 10, 2025
Comment thread
sdk/python/feast/cli.py
| config_dict.pop("repo_path", None) | ||
| print(yaml.dump(config_dict, default_flow_style=False, sort_keys=False)) | ||
| else: | ||
| print("No configuration found.") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice! Any chance you can add a unit test?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
and also update the dev guide docs, thanks!
Sorry, something went wrong.
…the same Signed-off-by: ShaktidharK1997 <shaktidhark.1997@gmail.com>
franciscojavierarceo
approved these changes
Feb 11, 2025
franciscojavierarceo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!!
Sorry, something went wrong.
redhatHameed
approved these changes
Feb 11, 2025
redhatHameed
enabled auto-merge (squash)
February 11, 2025 16:05
franciscojavierarceo
pushed a commit
that referenced
this pull request
Feb 17, 2025
# [0.46.0](v0.45.0...v0.46.0) (2025-02-17) ### Bug Fixes * Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed)) * Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35)) * Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a)) * Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b)) * Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447)) * Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548)) * Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4)) * Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa)) * Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca)) ### Features * Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21)) * Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d)) * Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7)) * Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7)) * Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new CLI command, feast configuration, to dump the actual configuration being used by Feast. This includes both user-provided configurations and default configurations applied by Feast. This feature is particularly useful for debugging and ensuring transparency in how configurations are interpreted, especially when defaults are applied.
For example, if a user provides a partial configuration, Feast will automatically apply default values for missing fields. The new CLI command will expose the complete configuration, including these defaults, in a human-readable format.
Example usage:
Example output:
Which issue(s) this PR fixes:
Fixes #4622
Misc
@dmartinol