feat: Adding docling to feast as add on - #5065
Closed
franciscojavierarceo wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dmartinol
reviewed
Feb 18, 2025
Comment thread
setup.py
|
|
||
| MILVUS_REQUIRED = ["pymilvus"] | ||
|
|
||
| RAG_REQUIRED = ["docling"] |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
unversioned?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I was going to figure out which version was most appropriate unbounded but this uncovered the broader issue of us having to move to pyproject.toml over the setup.py so we'll have to work on that first.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
And it looks like it's being handled here! #5067
Sorry, something went wrong.
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
docling
branch
from
016d107 to
927c2cf
Compare
February 19, 2025 01:18
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding docling to feast as add on
Which issue(s) this PR fixes:
Misc