chore: Assign the dummy entity a value type - #5098
Merged
redhatHameed merged 1 commit intoFeb 26, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Blake <blaketastic2@gmail.com>
franciscojavierarceo
approved these changes
Feb 26, 2025
franciscojavierarceo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice thank you
Sorry, something went wrong.
redhatHameed
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Meant to clean up the following log message:
DeprecationWarning: Entity value_type will be mandatory in the next release. Please specify a value_type for entity '__dummy'. DUMMY_ENTITY = Entity(
Which issue(s) this PR fixes:
Related to #4833 and #5092
Misc
The choice of using ValueType.UNKNOWN was simply to pick something as the default.