ci: Maturin-related builds from source - #5270
Merged
tchughesiv merged 1 commit intoApr 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tchughesiv
force-pushed
the
maturin3
branch
4 times, most recently
from
c16ab31 to
c24b812
Compare
April 17, 2025 00:57
tchughesiv
marked this pull request as ready for review
April 17, 2025 14:00
tchughesiv
enabled auto-merge (squash)
April 17, 2025 14:00
tchughesiv
marked this pull request as draft
April 17, 2025 14:28
auto-merge was automatically disabled
April 17, 2025 14:28
Pull request was converted to draft
jyejare
approved these changes
Apr 17, 2025
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
tchughesiv
marked this pull request as ready for review
April 17, 2025 17:31
tchughesiv
enabled auto-merge (squash)
April 17, 2025 17:31
Copy link
Copy Markdown
Member
|
@ntkathole @jyejare can we make a ticket to follow up on Milvus? |
Sorry, something went wrong.
franciscojavierarceo
approved these changes
Apr 17, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jfw-ppi
pushed a commit
to jfw-ppi/feast
that referenced
this pull request
Jun 7, 2025
maturin builds Signed-off-by: Tommy Hughes <tohughes@redhat.com> Signed-off-by: Jacob Weinhold <29459386+j-wine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Continues efforts toward a complete build from source for the feature-server image. This PR gets us almost all the way there... only 1 package remains as a binary install. This PR supports source builds for the following addional python package dependencies -
Also, for our minimal install in the feature-server image ... we replace the psycopg-binary with a psycopg[c] install. This package is a direct replacement, is recommended in production installs, and it allows us to build the full psycopg adapter from source. This has been tested in a feature store environment with a PostgreSQL data store.
https://www.psycopg.org/psycopg3/docs/basic/install.html#local-installation
Which issue(s) this PR fixes:
Relates to #5193
Fixes #5269
Misc
A milvus-lite package source build will require enhancements from the hermeto tool in order to support fetches for the conan package manager.
We added separate release offline script/Dockerfile