FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add aggregation in OnDemandFeatureView by HaoXuAI · Pull Request #5629 · feast-dev/feast · GitHub

/ feast Public

feat: Add aggregation in OnDemandFeatureView - #5629

Merged
HaoXuAI merged 5 commits into
masterfrom
on-demand-feature-view-agg
Sep 26, 2025
ConversationCommits (5)ChecksFiles changed
Merged

feat: Add aggregation in OnDemandFeatureView#5629
HaoXuAI merged 5 commits into
masterfrom
on-demand-feature-view-agg

Conversation

HaoXuAI commented Sep 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:

Misc

HaoXuAI requested a review from a team as a code owner September 24, 2025 17:04
add aggregation in OnDemandFeatureView
e707552 
Signed-off-by: hao-xu5 <hxu44@apple.com>
HaoXuAI force-pushed the on-demand-feature-view-agg branch from 0a624ec to e707552 Compare September 24, 2025 17:06
HaoXuAI changed the title Add aggregation in OnDemandFeatureView feat: Add aggregation in OnDemandFeatureView Sep 24, 2025
franciscojavierarceo approved these changes Sep 24, 2025
View reviewed changes

franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this is only including it, is the execution already supported?

franciscojavierarceo mentioned this pull request Sep 24, 2025
Open

HaoXuAI commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator Author

this is only including it, is the execution already supported?

Yeah It's only adding the API but the behind compute engine should be able to use it for batch compute

franciscojavierarceo commented Sep 24, 2025

Copy link
Copy Markdown
Member

cool, i'd recommend adding a test for it just to show.

HaoXuAI commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

cool, i'd recommend adding a test for it just to show.

yep, not completed yet. need to update the proto as well

udpate proto
8d8dcde 
Signed-off-by: hao-xu5 <hxu44@apple.com>
fix lint
d0aa3d6 
Signed-off-by: hao-xu5 <hxu44@apple.com>
HaoXuAI and others added 2 commits September 25, 2025 22:29

HaoXuAI commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator Author

@franciscojavierarceo mind take an another look

HaoXuAI merged commit 8715ae8 into master Sep 26, 2025
18 checks passed

franciscojavierarceo commented Sep 27, 2025

Copy link
Copy Markdown
Member

Yeah just did, I didn't see a test showing the usage fwiw

HaoXuAI commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator Author

Yeah just did, I didn't see a test showing the usage fwiw

Oh god forgot it. Will add in next pr

franciscojavierarceo pushed a commit that referenced this pull request Sep 30, 2025
chore(release): release 0.54.0
99a321a 
# [0.54.0](v0.53.0...v0.54.0) (2025-09-30)

### Bug Fixes

* Column quoting in query of `PostgreSQLOfflineStore.pull_all_from_table_or_query` ([#5621](#5621)) ([e8eae71](e8eae71))
* Correct column list polars materialization engine ([#5595](#5595)) ([39aeb0c](39aeb0c))
* Fix Go feature server entitykey serialization for version 3 ([#5622](#5622)) ([5ab18a6](5ab18a6))
* Fix hostname resolution for spark tests ([#5610](#5610)) ([8f0e22d](8f0e22d))
* Fixed filtering based on data_source for ODFVs ([#5593](#5593)) ([c3e6c56](c3e6c56))
* Fixed project_description to set in registry and UI ([#5602](#5602)) ([02c3006](02c3006))
* Fixed Registry Cache Refresh Issues ([#5604](#5604)) ([3c7a022](3c7a022))
* Fixed tls issue when running both grpc and rest servers ([#5617](#5617)) ([51c16b1](51c16b1))
* Fixed transaction handling with SQLite registry ([#5588](#5588)) ([0052754](0052754))
* Update the deprecated functions in Go feature server. ([#5632](#5632)) ([a24e06e](a24e06e))
* Updated python packages conflicting with kserve dependencies ([#5580](#5580)) ([d56baf4](d56baf4))

### Features

* Add 'featureView' in global search api result for features. ([#5626](#5626)) ([76590bf](76590bf))
* Add aggregation in OnDemandFeatureView ([#5629](#5629)) ([8715ae8](8715ae8))
* Added codeflare-sdk to requirements ([#5640](#5640)) ([51a0ee6](51a0ee6))
* Added RemoteDatasetProxy that executes Ray Data operations remotely ([7128024](7128024))
* Added support for image search ([#5577](#5577)) ([56c5910](56c5910))
* Enable ingestion without event timestamp ([#5625](#5625)) ([eb51f00](eb51f00))
* Feast dataframe phase1 ([#5611](#5611)) ([2ce4198](2ce4198))
* Feast dataframe phase2 ([#5612](#5612)) ([1d08786](1d08786))
* Feast Namespaces registry for client ConfigMaps availability ([#5599](#5599)) ([728589a](728589a))
* Support hdfs:// uris in to_remote_storage for Spark offline store ([#5635](#5635)) ([5e4b9fd](5e4b9fd))

franciscojavierarceo commented Nov 17, 2025

Copy link
Copy Markdown
Member

@HaoXuAI you creating aa follow up PR?

franciscojavierarceo mentioned this pull request Jan 14, 2026
Open
Copilot AI mentioned this pull request Jan 14, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

franciscojavierarceo franciscojavierarceo approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL