FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Loosen pyarrow by dlovell · Pull Request #5661 · feast-dev/feast · GitHub

chore: Loosen pyarrow - #5661

Merged
ntkathole merged 4 commits into
feast-dev:masterfrom
xorq-labs:chore/deps/loosen-pyarrow
Oct 14, 2025
Merged

chore: Loosen pyarrow#5661
ntkathole merged 4 commits into
feast-dev:masterfrom
xorq-labs:chore/deps/loosen-pyarrow

Conversation

dlovell commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR loosens the pyarrow requirement to allow for more recent pyarrow versions

Which issue(s) this PR fixes:

fixes #5609

dlovell marked this pull request as draft October 13, 2025 13:15
dlovell changed the title chore(deps): loosen pyarrow chore(deps): Loosen pyarrow Oct 13, 2025
franciscojavierarceo changed the title chore(deps): Loosen pyarrow chore: Loosen pyarrow Oct 13, 2025

franciscojavierarceo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can you update setup.py and then run make install-python-dependencies-dev?

Signed-off-by: dlovell <dlovell@gmail.com>
Signed-off-by: dlovell <dlovell@gmail.com>
dlovell force-pushed the chore/deps/loosen-pyarrow branch from 4c06ac4 to d56c8f6 Compare October 13, 2025 13:52
dlovell marked this pull request as ready for review October 13, 2025 14:11
dlovell requested a review from a team as a code owner October 13, 2025 14:11

Copy link
Copy Markdown
Member

hmm looks like macos-14 doesn't like it @ntkathole can you provide some guidance here?

dlovell commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

i'm not sure i created my venv with make install-python-dependencies-dev

i'll start over with a venv created that way

dlovell commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

looks like nvidia-* causes macos to fail and nvidia-* comes from torch / image comes from ci

Copy link
Copy Markdown
Member

looks like nvidia-* causes macos to fail and nvidia-* comes from torch / image comes from ci

The requirement file included in PR has nvidia-* dependencies which is only meant for GPU supported systems. You need to make sure make lock-python-dependencies-all do not include those dependencies, I think probably using PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu

Copy link
Copy Markdown
Member

Also, fyi - we have APACHE_ARROW_VERSION="17.0.0" added in feast-operator images, which needs to be updated as well.
https://github.com/search?q=repo%3Afeast-dev%2Ffeast%20APACHE_ARROW_VERSION&type=code

dlovell force-pushed the chore/deps/loosen-pyarrow branch from 3777db6 to 7a46e80 Compare October 13, 2025 16:54

dlovell commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

@ntkathole FYI: i've modified lock-python-dependencies-all to pass the args necessary to use the pytorch cpu index

its not clear that APACHE_ARROW_VERSION needs to change: its usages seem to be pointing to minimal installs of feast which still refer to 17.0.0

Signed-off-by: dlovell <dlovell@gmail.com>
dlovell force-pushed the chore/deps/loosen-pyarrow branch from 7a46e80 to af98a25 Compare October 13, 2025 17:47
ntkathole mentioned this pull request Oct 14, 2025

Copy link
Copy Markdown
Member

@ntkathole FYI: i've modified lock-python-dependencies-all to pass the args necessary to use the pytorch cpu index

Looks like it is appending +cpu to the requirement explicitly causing issues. I am not able to push to your branch, so created #5662

its not clear that APACHE_ARROW_VERSION needs to change: its usages seem to be pointing to minimal installs of feast which still refer to 17.0.0

I see, right. No need to update since it's still pin to 17.0.0

Signed-off-by: dlovell <dlovell@gmail.com>
dlovell force-pushed the chore/deps/loosen-pyarrow branch from af98a25 to e8e4b95 Compare October 14, 2025 09:58

dlovell commented Oct 14, 2025

Copy link
Copy Markdown
Contributor Author

@ntkathole FYI: this branch also includes a change to the ray / codeflare dependency environment marker. uv lock fails due to its use of python_full_version if this change is not present.

ntkathole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good

ntkathole merged commit 39c243e into feast-dev:master Oct 14, 2025
17 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The dependency "pyarrow<=17.0.0" does not work with Python 3.13

3 participants


Back | FazBrowse Home | New Git URL