| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
can you update setup.py and then run make install-python-dependencies-dev?
Sorry, something went wrong.
Signed-off-by: dlovell <dlovell@gmail.com>
Signed-off-by: dlovell <dlovell@gmail.com>
|
hmm looks like macos-14 doesn't like it @ntkathole can you provide some guidance here? |
Sorry, something went wrong.
|
i'm not sure i created my venv with make install-python-dependencies-dev i'll start over with a venv created that way |
Sorry, something went wrong.
|
looks like nvidia-* causes macos to fail and nvidia-* comes from torch / image comes from ci |
Sorry, something went wrong.
The requirement file included in PR has nvidia-* dependencies which is only meant for GPU supported systems. You need to make sure make lock-python-dependencies-all do not include those dependencies, I think probably using PIP_EXTRA_INDEX_URL=https://download.pytorch.org/whl/cpu |
Sorry, something went wrong.
|
Also, fyi - we have APACHE_ARROW_VERSION="17.0.0" added in feast-operator images, which needs to be updated as well. |
Sorry, something went wrong.
|
@ntkathole FYI: i've modified lock-python-dependencies-all to pass the args necessary to use the pytorch cpu index its not clear that APACHE_ARROW_VERSION needs to change: its usages seem to be pointing to minimal installs of feast which still refer to 17.0.0 |
Sorry, something went wrong.
Signed-off-by: dlovell <dlovell@gmail.com>
Looks like it is appending +cpu to the requirement explicitly causing issues. I am not able to push to your branch, so created #5662
I see, right. No need to update since it's still pin to 17.0.0 |
Sorry, something went wrong.
Signed-off-by: dlovell <dlovell@gmail.com>
|
@ntkathole FYI: this branch also includes a change to the ray / codeflare dependency environment marker. uv lock fails due to its use of python_full_version if this change is not present. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
This PR loosens the pyarrow requirement to allow for more recent pyarrow versions
Which issue(s) this PR fixes:
fixes #5609