| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I ran "make test-python-universal-clickhouse-offline", to make sure CH integration tests pass, they actually failed before adding the change, worked after adding the change, hopefully the same suite runs on CI as well :D. |
Sorry, something went wrong.
|
Failing unit tests:
Seem to be outside of my changes? 🤔 I see same issues in other latest MRs. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Those failures are due to pytorch releasing wheels early than pypi release. I have a fix #5668. Once merged, you can rebase and pipeline issue should fix. |
Sorry, something went wrong.
…terialization logic (calling it) Signed-off-by: lukas.valatka <lukas.valatka@cast.ai>
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
|
Thanks for fast responses and reviews! |
Sorry, something went wrong.
|
Let's merge? Not sure who can (I don't seem to have the option available). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
As discussed in #5493, from 0.50.0 materialize does not work against Clickhouse offline store, with the reason being pull_all_from_table_or_query missing in the CH store implementation.
The PR adjusts this by adding the method. Also, makes sure some typing tests are not excluded anymore, apparently they pass just fine now.
Which issue(s) this PR fixes:
#5493,
Misc