FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Skip tag updates if user do not have permissions by ntkathole · Pull Request #5673 · feast-dev/feast · GitHub

/ feast Public

fix: Skip tag updates if user do not have permissions #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Oct 16, 2025
Conversation 0 Commits 1 Checks 21 Files changed
Merged

fix: Skip tag updates if user do not have permissions #5673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
13 changes: 12 additions & 1 deletion sdk/python/feast/infra/online_stores/dynamodb.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,18 @@ def update(
# tags won't be updated in the create_table call if the table already exists
if do_tag_updates[table_name]:
tags = self._table_tags(online_config, table_instance)
self._update_tags(dynamodb_client, table_name, tags)
try:
self._update_tags(dynamodb_client, table_name, tags)
except ClientError as ce:
# If tag update fails with AccessDeniedException, log warning and continue
# This allows Feast to work in environments where IAM roles don't have
# dynamodb:TagResource and dynamodb:UntagResource permissions
if ce.response["Error"]["Code"] == "AccessDeniedException":
logger.warning(
f"Unable to update tags for table {table_name} due to insufficient permissions."
)
else:
raise

for table_to_delete in tables_to_delete:
_delete_table_idempotent(
Expand Down
Loading
Back | FazBrowse Home | New Git URL