FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add flexible commandArgs support for complete Feast CLI control by blaketastic2 · Pull Request #5678 · feast-dev/feast · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .md  (1) .yaml  (2) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions infra/charts/feast-feature-server/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
| Key | Type | Default | Description |
|-----|------|---------|-------------|
| affinity | object | `{}` | |
| commandArgs | list | `[]` | Override the default command arguments for complete control over CLI options |
| extraEnvs | list | `[]` | Additional environment variables to be set in the container |
| feast_mode | string | `"online"` | Feast supported deployment modes - online (default), offline, ui and registry |
| feature_store_yaml_base64 | string | `""` | [required] a base64 encoded version of feature_store.yaml |
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ spec:
{{- toYaml . | nindent 12 }}
{{- end}}
command:
{{- if .Values.commandArgs }}
{{- toYaml .Values.commandArgs | nindent 12 }}
{{- else }}
{{- /* Fallback to legacy behavior for backward compatibility */}}
{{- if eq .Values.feast_mode "offline" }}
- "feast"
- "--log-level"
Expand Down Expand Up @@ -82,6 +86,7 @@ spec:
- "0.0.0.0"
{{- end }}
{{- end }}
{{- end }}
ports:
- name: {{ .Values.feast_mode }}
{{- if eq .Values.feast_mode "offline" }}
Expand Down
18 changes: 18 additions & 0 deletions infra/charts/feast-feature-server/values.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,24 @@ feature_store_yaml_base64: ""
# feast_mode -- Feast supported deployment modes - online (default), offline, ui and registry
feast_mode: "online"

# commandArgs -- Override the default command arguments for complete control over CLI options
# If not specified, falls back to legacy behavior based on feast_mode
# Example for UI mode with custom options:
# commandArgs:
# - "feast"
# - "--log-level"
# - "INFO"
# - "ui"
# - "--root_path"
# - "/feast"
# - "--registry_ttl_sec"
# - "300"
# - "-h"
# - "0.0.0.0"
# - "-p"
# - "8888"
commandArgs: []

podAnnotations: {}

podSecurityContext: {}
Expand Down
Loading

Back | FazBrowse Home | New Git URL