FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Add hybrid online store to ONLINE_STORE_CLASS_FOR_TYPE mapping by YassinNouh21 · Pull Request #5810 · feast-dev/feast · GitHub

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .go  (2) .md  (1) .py  (3) .yaml  (2) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion docs/reference/online-stores/hybrid.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ project: my_feature_repo
registry: data/registry.db
provider: local
online_store:
type: hybrid_online_store.HybridOnlineStore
type: hybrid
routing_tag: team # or any tag name you want to use in FeatureView's for routing
online_stores:
- type: bigtable
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ type OnlineStoreFilePersistence struct {
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
type OnlineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -396,6 +396,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
"qdrant",
"couchbase.online",
"milvus",
"hybrid",
}

// LocalRegistryConfig configures the registry service
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ type OnlineStoreFilePersistence struct {
// OnlineStoreDBStorePersistence configures the DB store persistence for the online store service
type OnlineStoreDBStorePersistence struct {
// Type of the persistence type you want to use.
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase.online;milvus;hybrid
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -396,6 +396,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
"qdrant",
"couchbase.online",
"milvus",
"hybrid",
}

// LocalRegistryConfig configures the registry service
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1322,6 +1322,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -5358,6 +5359,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -9521,6 +9523,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -13557,6 +13560,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down
4 changes: 4 additions & 0 deletions infra/feast-operator/dist/install.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -1330,6 +1330,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -5366,6 +5367,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -9529,6 +9531,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down Expand Up @@ -13565,6 +13568,7 @@ spec:
- qdrant
- couchbase.online
- milvus
- hybrid
type: string
required:
- secretRef
Expand Down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Example configuration (feature_store.yaml):

online_store:
type: hybrid_online_store.HybridOnlineStore
type: hybrid
routing_tag: team # or any tag name you want to use for routing
online_stores:
- type: feast.infra.online_stores.bigtable.BigtableOnlineStore
Expand Down Expand Up @@ -64,9 +64,7 @@ class HybridOnlineStoreConfig(FeastConfigBaseModel):
online_stores: A list of OnlineStoresWithConfig, each specifying the type and config for an online store backend.
"""

type: Literal["HybridOnlineStore", "hybrid_online_store.HybridOnlineStore"] = (
"hybrid_online_store.HybridOnlineStore"
)
type: Literal["hybrid"] = "hybrid"

class OnlineStoresWithConfig(FeastConfigBaseModel):
"""
Expand Down
1 change: 1 addition & 0 deletions sdk/python/feast/repo_config.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
"qdrant": "feast.infra.online_stores.qdrant_online_store.qdrant.QdrantOnlineStore",
"couchbase.online": "feast.infra.online_stores.couchbase_online_store.couchbase.CouchbaseOnlineStore",
"milvus": "feast.infra.online_stores.milvus_online_store.milvus.MilvusOnlineStore",
"hybrid": "feast.infra.online_stores.hybrid_online_store.hybrid_online_store.HybridOnlineStore",
**LEGACY_ONLINE_STORE_CLASS_FOR_TYPE,
}

Expand Down
Loading

Back | FazBrowse Home | New Git URL