| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
| with: | ||
| enable-cache: true | ||
|
|
||
| - name: Install dependencies |
There was a problem hiding this comment.
@copilot we should use the Makefile to install dependencies here
Sorry, something went wrong.
There was a problem hiding this comment.
Updated to use make install-python-dependencies-ci in commit 621cefb.
Sorry, something went wrong.
| path: ':memory:' | ||
| threads: 1 | ||
|
|
||
| bigquery_test: |
There was a problem hiding this comment.
@copilot we should noly test with the sqlite setup, no need for us to use bigquery or snowflake imo
Sorry, something went wrong.
There was a problem hiding this comment.
Removed BigQuery and Snowflake profiles, kept only DuckDB setup in commit e25d08f.
Sorry, something went wrong.
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
| uv pip install --system -e "." | ||
| uv pip install --system dbt-artifacts-parser pytest pytest-xdist | ||
|
|
||
| - name: Run dbt integration tests |
There was a problem hiding this comment.
@copillot we should also run the standard dbt commands; i.e,.
dbt run
dbt build
dbt testafter that we should then test the new feast cli and test that feast materialization works from a dbt model into a sqlite online store.
Sorry, something went wrong.
There was a problem hiding this comment.
Added dbt commands (deps, build, test) and Feast CLI testing with SQLite online store in commit ba38da0. The workflow now:
Sorry, something went wrong.
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
There was a problem hiding this comment.
See inline comments for specific fixes needed.
Sorry, something went wrong.
There was a problem hiding this comment.
fix those issues copilot
Sorry, something went wrong.
There was a problem hiding this comment.
Found several API mismatches that will cause test failures
Sorry, something went wrong.
|
|
||
| def test_create_feature_view(self, parser): | ||
| """Test creating Feast FeatureView from dbt model.""" | ||
| mapper = DbtToFeastMapper(data_source_type="bigquery") |
There was a problem hiding this comment.
entity.join_keys should be entity.join_key - Entity uses singular string, not a list
Sorry, something went wrong.
There was a problem hiding this comment.
@copilot please revise
Sorry, something went wrong.
|
|
||
| # Check that schema excludes entity and timestamp columns | ||
| feature_names = {f.name for f in feature_view.schema} | ||
| assert "driver_id" not in feature_names # Entity column excluded |
There was a problem hiding this comment.
feature_view.entities[0] contains entity names as strings, not Entity objects. Should be: assert feature_view.entities[0] == entity.name
Sorry, something went wrong.
There was a problem hiding this comment.
@copilot please revise
Sorry, something went wrong.
| def test_code_generation_workflow(self, parser): | ||
| """Test workflow that generates Python code.""" | ||
| models = parser.get_models(model_names=["driver_features"]) | ||
|
|
There was a problem hiding this comment.
Incorrect count. With 3 models you get: 3 DataSources + 3 Entities + 3 FeatureViews = 9 objects total. Should be: assert len(all_objects) == 9
Sorry, something went wrong.
There was a problem hiding this comment.
@copilot please revise
Sorry, something went wrong.
|
@franciscojavierarceo Found some issues in this PR that need attention: Critical bugs (will cause test failures):
Architecture concerns:
The inline comments on lines 191, 215, 488 show the exact fixes needed for the critical bugs. Happy to help if you need clarification on any of these. |
Sorry, something went wrong.
|
@YassinNouh21 you have to tag @copilot in every comment for it to update the code 😅 |
Sorry, something went wrong.
|
@franciscojavierarceo I thought he will continue working on it 😂 |
Sorry, something went wrong.
Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
…generate it Co-authored-by: franciscojavierarceo <4163062+franciscojavierarceo@users.noreply.github.com>
Fixed in commit 586f825. The issue was an incorrectly pre-committed manifest.json from unit tests (with wrong project name "sample_dbt_project" instead of "feast_integration_test"). The manifest is now generated fresh by dbt build in the CI workflow before tests run. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
What this PR does / why we need it:
Adds comprehensive integration tests for the dbt import feature (PR #5827), which previously lacked end-to-end testing with actual dbt project setup and Feast CLI integration.
Changes
Test Infrastructure
Test dbt Project
CI/CD - End-to-End Workflow
Bug Fixes
Test Example
Which issue(s) this PR fixes:
Related to #3335
Misc
Comprehensive documentation added for test structure and dbt project. The workflow now provides complete end-to-end testing from dbt model definition through to Feast feature store integration, including actual data materialization to SQLite online store. The manifest.json is dynamically generated during CI to ensure tests validate real dbt compilation output.
Original prompt💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.