FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Reenable tests by tokoko · Pull Request #6036 · feast-dev/feast · GitHub

/ feast Public

fix: Reenable tests #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tokoko merged 2 commits into from
Mar 1, 2026
Conversation 4 Commits 2 Checks 23 Files changed
Merged

fix: Reenable tests #6036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5a03c7
fix: reenable tests
tokoko Mar 1, 2026
a620c44
fix: unit tests
tokoko Mar 1, 2026
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion sdk/python/feast/type_map.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ def pa_to_feast_value_type(pa_type_as_str: str) -> ValueType:
elif pa_type_as_str.startswith("map<"):
value_type = ValueType.MAP
elif pa_type_as_str == "large_string":
value_type = ValueType.STRING
value_type = ValueType.JSON
elif pa_type_as_str.startswith("struct<") or pa_type_as_str.startswith("struct{"):
value_type = ValueType.STRUCT
else:
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/tests/integration/dbt/conftest.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,7 @@ def pytest_collection_modifyitems(config, items): # noqa: ARG001
reason="dbt manifest.json not found - run 'dbt build' first or use dbt-integration-test workflow"
)
for item in items:
item.add_marker(skip_marker)
if str(TEST_DBT_PROJECT_DIR) in str(item.fspath) or "/dbt/" in str(
item.fspath
):
item.add_marker(skip_marker)
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/local_feast_tests/test_feature_service.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_apply_with_fv_inference() -> None:

fs = store.get_feature_service("all_stats")
assert len(fs.feature_view_projections) == 2
assert len(fs.feature_view_projections[0].features) == 3
assert len(fs.feature_view_projections[0].features) == 6
assert len(fs.feature_view_projections[0].desired_features) == 0
assert len(fs.feature_view_projections[1].features) == 2
assert len(fs.feature_view_projections[1].desired_features) == 0
Expand Down
Loading
Back | FazBrowse Home | New Git URL