FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Add feast apply init container to automate registry population on pod start by ntkathole · Pull Request #6106 · feast-dev/feast · GitHub

/ feast Public

feat: Add feast apply init container to automate registry population on pod start #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 4 commits into from
Mar 15, 2026
Conversation 9 Commits 4 Checks 27 Files changed
Merged

feat: Add feast apply init container to automate registry population on pod start #6106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2089f9d
feat: Add feast apply init container to automate registry population …
ntkathole Mar 14, 2026
265e9dc
fix: Replicas is not required
ntkathole Mar 14, 2026
61c77a5
fix: Fixed race condition in _apply_object
ntkathole Mar 15, 2026
c9be7aa
fix: Improve error messaging
ntkathole Mar 15, 2026
File filter

Filter by extension

Filter by extension .baseline  (1) .go  (13) .md  (1) .py  (1) .yaml  (2) All 5 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
18 changes: 9 additions & 9 deletions .secrets.baseline
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@
"filename": "infra/feast-operator/api/v1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 727
"line_number": 729
}
],
"infra/feast-operator/api/v1/zz_generated.deepcopy.go": [
Expand All @@ -943,21 +943,21 @@
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "f914fc9324de1bec1ad13dec94a8ea2ddb41fc87",
"is_verified": false,
"line_number": 681
"line_number": 686
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 1249
"line_number": 1254
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1/zz_generated.deepcopy.go",
"hashed_secret": "c2028031c154bbe86fd69bef740855c74b927dcf",
"is_verified": false,
"line_number": 1254
"line_number": 1259
}
],
"infra/feast-operator/api/v1alpha1/featurestore_types.go": [
Expand All @@ -966,7 +966,7 @@
"filename": "infra/feast-operator/api/v1alpha1/featurestore_types.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 647
"line_number": 649
}
],
"infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go": [
Expand All @@ -975,21 +975,21 @@
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "f914fc9324de1bec1ad13dec94a8ea2ddb41fc87",
"is_verified": false,
"line_number": 590
"line_number": 595
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "44e17306b837162269a410204daaa5ecee4ec22c",
"is_verified": false,
"line_number": 1098
"line_number": 1103
},
{
"type": "Secret Keyword",
"filename": "infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go",
"hashed_secret": "c2028031c154bbe86fd69bef740855c74b927dcf",
"is_verified": false,
"line_number": 1103
"line_number": 1108
}
],
"infra/feast-operator/config/samples/v1_featurestore_db_persistence.yaml": [
Expand Down Expand Up @@ -1539,5 +1539,5 @@
}
]
},
"generated_at": "2026-03-10T18:11:57Z"
"generated_at": "2026-03-14T16:01:28Z"
}
4 changes: 3 additions & 1 deletion infra/feast-operator/api/v1/featurestore_types.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ type FeatureStoreSpec struct {
// Mutually exclusive with services.scaling.autoscaling.
// +kubebuilder:default=1
// +kubebuilder:validation:Minimum=1
Replicas *int32 `json:"replicas"`
Replicas *int32 `json:"replicas,omitempty"`
}

// FeastProjectDir defines how to create the feast project directory.
Expand Down Expand Up @@ -310,6 +310,8 @@ type FeatureStoreServices struct {
SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"`
// Disable the 'feast repo initialization' initContainer
DisableInitContainers bool `json:"disableInitContainers,omitempty"`
// Runs feast apply on pod start to populate the registry. Defaults to true. Ignored when DisableInitContainers is true.
RunFeastApplyOnInit *bool `json:"runFeastApplyOnInit,omitempty"`
// Volumes specifies the volumes to mount in the FeatureStore deployment. A corresponding `VolumeMount` should be added to whichever feast service(s) require access to said volume(s).
Volumes []corev1.Volume `json:"volumes,omitempty"`
// Scaling configures horizontal scaling for the FeatureStore deployment (e.g. HPA autoscaling).
Expand Down
5 changes: 5 additions & 0 deletions infra/feast-operator/api/v1/zz_generated.deepcopy.go
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions infra/feast-operator/api/v1alpha1/featurestore_types.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,8 @@ type FeatureStoreServices struct {
SecurityContext *corev1.PodSecurityContext `json:"securityContext,omitempty"`
// Disable the 'feast repo initialization' initContainer
DisableInitContainers bool `json:"disableInitContainers,omitempty"`
// Runs feast apply on pod start to populate the registry. Defaults to true. Ignored when DisableInitContainers is true.
RunFeastApplyOnInit *bool `json:"runFeastApplyOnInit,omitempty"`
// Volumes specifies the volumes to mount in the FeatureStore deployment. A corresponding `VolumeMount` should be added to whichever feast service(s) require access to said volume(s).
Volumes []corev1.Volume `json:"volumes,omitempty"`
}
Expand Down
5 changes: 5 additions & 0 deletions infra/feast-operator/api/v1alpha1/zz_generated.deepcopy.go
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 18 additions & 2 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3129,6 +3129,10 @@ spec:
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c, c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the registry.
Defaults to true. Ignored when DisableInitContainers is true.
type: boolean
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
scaling:
description: Scaling configures horizontal scaling for the FeatureStore
deployment (e.g. HPA autoscaling).
Expand Down Expand Up @@ -5695,7 +5699,6 @@ spec:
type: object
required:
- feastProject
- replicas
type: object
x-kubernetes-validations:
- message: replicas > 1 and services.scaling.autoscaling are mutually
Expand Down Expand Up @@ -8871,6 +8874,11 @@ spec:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c,
c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the
registry. Defaults to true. Ignored when DisableInitContainers
is true.
type: boolean
scaling:
description: Scaling configures horizontal scaling for the
FeatureStore deployment (e.g. HPA autoscaling).
Expand Down Expand Up @@ -11458,7 +11466,6 @@ spec:
type: object
required:
- feastProject
- replicas
type: object
x-kubernetes-validations:
- message: replicas > 1 and services.scaling.autoscaling are mutually
Expand Down Expand Up @@ -13920,6 +13927,10 @@ spec:
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c, c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the registry.
Defaults to true. Ignored when DisableInitContainers is true.
type: boolean
securityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings.
Expand Down Expand Up @@ -18163,6 +18174,11 @@ spec:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c,
c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the
registry. Defaults to true. Ignored when DisableInitContainers
is true.
type: boolean
securityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings.
Expand Down
20 changes: 18 additions & 2 deletions infra/feast-operator/dist/install.yaml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3137,6 +3137,10 @@ spec:
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c, c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the registry.
Defaults to true. Ignored when DisableInitContainers is true.
type: boolean
scaling:
description: Scaling configures horizontal scaling for the FeatureStore
deployment (e.g. HPA autoscaling).
Expand Down Expand Up @@ -5703,7 +5707,6 @@ spec:
type: object
required:
- feastProject
- replicas
type: object
x-kubernetes-validations:
- message: replicas > 1 and services.scaling.autoscaling are mutually
Expand Down Expand Up @@ -8879,6 +8882,11 @@ spec:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c,
c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the
registry. Defaults to true. Ignored when DisableInitContainers
is true.
type: boolean
scaling:
description: Scaling configures horizontal scaling for the
FeatureStore deployment (e.g. HPA autoscaling).
Expand Down Expand Up @@ -11466,7 +11474,6 @@ spec:
type: object
required:
- feastProject
- replicas
type: object
x-kubernetes-validations:
- message: replicas > 1 and services.scaling.autoscaling are mutually
Expand Down Expand Up @@ -13928,6 +13935,10 @@ spec:
x-kubernetes-validations:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c, c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the registry.
Defaults to true. Ignored when DisableInitContainers is true.
type: boolean
securityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings.
Expand Down Expand Up @@ -18171,6 +18182,11 @@ spec:
- message: One selection required.
rule: '[has(self.local), has(self.remote)].exists_one(c,
c)'
runFeastApplyOnInit:
description: Runs feast apply on pod start to populate the
registry. Defaults to true. Ignored when DisableInitContainers
is true.
type: boolean
securityContext:
description: PodSecurityContext holds pod-level security attributes
and common container settings.
Expand Down
1 change: 1 addition & 0 deletions infra/feast-operator/docs/api/markdown/ref.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ _Appears in:_
| `deploymentStrategy` _[DeploymentStrategy](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#deploymentstrategy-v1-apps)_ | |
| `securityContext` _[PodSecurityContext](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#podsecuritycontext-v1-core)_ | |
| `disableInitContainers` _boolean_ | Disable the 'feast repo initialization' initContainer |
| `runFeastApplyOnInit` _boolean_ | Runs feast apply on pod start to populate the registry. Defaults to true. Ignored when DisableInitContainers is true. |
| `volumes` _[Volume](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#volume-v1-core) array_ | Volumes specifies the volumes to mount in the FeatureStore deployment. A corresponding `VolumeMount` should be added to whichever feast service(s) require access to said volume(s). |
| `scaling` _[ScalingConfig](#scalingconfig)_ | Scaling configures horizontal scaling for the FeatureStore deployment (e.g. HPA autoscaling).
For static replicas, use spec.replicas instead. |
Expand Down
6 changes: 5 additions & 1 deletion infra/feast-operator/internal/controller/featurestore_controller.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,15 @@ func (r *FeatureStoreReconciler) deployFeast(ctx context.Context, cr *feastdevv1
} else {
isDeployAvailable := services.IsDeploymentAvailable(deployment.Status.Conditions)
if !isDeployAvailable {
msg := feastdevv1.DeploymentNotAvailableMessage
if podMsg := feast.GetPodContainerFailureMessage(deployment); podMsg != "" {
msg = msg + ": " + podMsg
}
condition = metav1.Condition{
Type: feastdevv1.ReadyType,
Status: metav1.ConditionUnknown,
Reason: feastdevv1.DeploymentNotAvailableReason,
Message: feastdevv1.DeploymentNotAvailableMessage,
Message: msg,
}

result = errResult
Expand Down
2 changes: 2 additions & 0 deletions infra/feast-operator/internal/controller/featurestore_controller_cronjob_test.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ var _ = Describe("FeatureStore Controller - Feast CronJob", func() {
Expect(resource.Status).NotTo(BeNil())
Expect(resource.Status.CronJob).To(Equal(objMeta.Name))
Expect(resource.Status.Applied.CronJob.Schedule).NotTo(BeEmpty())
Expect(resource.Status.Applied.Services.RunFeastApplyOnInit).NotTo(BeNil())
Expect(*resource.Status.Applied.Services.RunFeastApplyOnInit).To(BeTrue())

Expect(resource.Status.Conditions).NotTo(BeEmpty())
cond := apimeta.FindStatusCondition(resource.Status.Conditions, feastdevv1.CronJobReadyType)
Expand Down
2 changes: 1 addition & 1 deletion infra/feast-operator/internal/controller/featurestore_controller_objectstore_test.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ var _ = Describe("FeatureStore Controller-Ephemeral services", func() {
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Replicas).To(Equal(int32Ptr(1)))
Expect(controllerutil.HasControllerReference(deploy)).To(BeTrue())
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.Containers).To(HaveLen(2))
Expect(services.GetRegistryContainer(*deploy)).NotTo(BeNil())
Expect(services.GetOnlineContainer(*deploy)).NotTo(BeNil())
Expand Down
2 changes: 1 addition & 1 deletion infra/feast-operator/internal/controller/featurestore_controller_oidc_auth_test.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ var _ = Describe("FeatureStore Controller-OIDC authorization", func() {
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Replicas).To(Equal(int32Ptr(1)))
Expect(controllerutil.HasControllerReference(deploy)).To(BeTrue())
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.Containers).To(HaveLen(4))
Expect(deploy.Spec.Template.Spec.Volumes).To(HaveLen(1))
Expect(services.GetOfflineContainer(*deploy).VolumeMounts).To(HaveLen(1))
Expand Down
16 changes: 12 additions & 4 deletions infra/feast-operator/internal/controller/featurestore_controller_test.go
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,10 @@ var _ = Describe("FeatureStore Controller", func() {
Expect(deploy.Spec.Replicas).To(Equal(int32Ptr(1)))
Expect(controllerutil.HasControllerReference(deploy)).To(BeTrue())
Expect(deploy.Spec.Template.Spec.ServiceAccountName).To(Equal(deploy.Name))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.InitContainers[0].Args[0]).To(ContainSubstring("feast init"))
Expect(deploy.Spec.Template.Spec.InitContainers[1].Name).To(Equal("feast-apply"))
Expect(deploy.Spec.Template.Spec.InitContainers[1].Command).To(Equal([]string{"feast", "apply"}))
Expect(deploy.Spec.Template.Spec.Containers).To(HaveLen(1))

deploy.Spec.Replicas = int32Ptr(3)
Expand Down Expand Up @@ -264,7 +266,7 @@ var _ = Describe("FeatureStore Controller", func() {
}, deploy)
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Replicas).To(Equal(int32Ptr(1)))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.InitContainers[0].Args[0]).To(ContainSubstring("git -c http.sslVerify=false clone"))
Expect(deploy.Spec.Template.Spec.InitContainers[0].Args[0]).To(ContainSubstring("git checkout " + ref))
Expect(deploy.Spec.Template.Spec.InitContainers[0].Args[0]).To(ContainSubstring(featureRepoPath))
Expand Down Expand Up @@ -294,7 +296,7 @@ var _ = Describe("FeatureStore Controller", func() {
Namespace: objMeta.Namespace,
}, deploy)
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.InitContainers[0].Args[0]).To(ContainSubstring("feast init -t spark"))
})

Expand Down Expand Up @@ -737,6 +739,12 @@ var _ = Describe("FeatureStore Controller", func() {
}, deploy)
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Template.Spec.ServiceAccountName).To(Equal(deploy.Name))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))
Expect(deploy.Spec.Template.Spec.InitContainers[1].Name).To(Equal("feast-apply"))
Expect(deploy.Spec.Template.Spec.InitContainers[1].Env).To(ContainElements(
corev1.EnvVar{Name: testEnvVarName, Value: testEnvVarValue},
))
Expect(deploy.Spec.Template.Spec.InitContainers[1].EnvFrom).NotTo(BeEmpty())
Expect(deploy.Spec.Template.Spec.Containers).To(HaveLen(4))
registryContainer := services.GetRegistryContainer(*deploy)
Expect(registryContainer.Env).To(HaveLen(1))
Expand Down Expand Up @@ -1145,7 +1153,7 @@ var _ = Describe("FeatureStore Controller", func() {
Namespace: objMeta.Namespace,
}, deploy)
Expect(err).NotTo(HaveOccurred())
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(1))
Expect(deploy.Spec.Template.Spec.InitContainers).To(HaveLen(2))

// check client config
cm := &corev1.ConfigMap{}
Expand Down
Loading
Loading
Back | FazBrowse Home | New Git URL