FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Add DocEmbedder documentation for PR #5973 by patelchaitany · Pull Request #6201 · feast-dev/feast · GitHub

/ feast Public

docs: Add DocEmbedder documentation for PR #5973 - #6201

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:docs/doc-embedder-pr-5973
Apr 14, 2026
ConversationCommits (1)ChecksFiles changed
Merged

docs: Add DocEmbedder documentation for PR #5973#6201
ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:docs/doc-embedder-pr-5973

Conversation

patelchaitany commented Mar 31, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Added DocEmbedder documentation to docs/getting-started/genai.md covering key components, quick example, and features
  • Added a full "Alternative: Using DocEmbedder" section to docs/tutorials/rag-with-docling.md with setup, retrieval, and detailed customization examples (custom chunker, embedder, and logical layer function)
  • Added DocEmbedder section to examples/rag-retriever/README.md with quick start and feature overview

Related to #5973

Test plan

  • Verify docs render correctly on the docs site
  • Verify all internal links resolve correctly
  • Verify code examples are syntactically correct

🤖 Generated with Claude Code

patelchaitany requested a review from a team as a code owner March 31, 2026 10:25
devin-ai-integration Bot reviewed Mar 31, 2026
View reviewed changes

devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from 1ff66e9 to 79a91f1 Compare March 31, 2026 12:08

patelchaitany commented Mar 31, 2026

Copy link
Copy Markdown
Contributor Author

Hey,@franciscojavierarceo I changed the name of the LogicalLayerFn -> SchemaMapperFn which is more intuitive than previous name Commets. Pls let me know if any changes required.

patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from 79a91f1 to 75fe26e Compare April 1, 2026 08:53

This comment was marked as resolved.

Sign in to view

shuchu approved these changes Apr 10, 2026
View reviewed changes

shuchu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

Add DocEmbedder docs and examples
c11a80e 
Signed-off-by: Chaitany patel <patelchaitany93@gmail.com>
patelchaitany force-pushed the docs/doc-embedder-pr-5973 branch from f215de9 to c11a80e Compare April 14, 2026 05:34
ntkathole merged commit 9b185ee into feast-dev:master Apr 14, 2026
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

devin-ai-integration[bot] devin-ai-integration[bot] left review comments
shuchu shuchu approved these changes
ntkathole ntkathole approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL