| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| - op: replace | ||
| path: "/spec/template/spec/containers/0/env/0" | ||
| value: | ||
| name: RELATED_IMAGE_FEATURE_SERVER | ||
| value: ${FS_IMG} | ||
| - op: replace | ||
| path: "/spec/template/spec/containers/0/env/1" | ||
| value: | ||
| name: RELATED_IMAGE_CRON_JOB | ||
| value: ${CJ_IMG} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: controller-manager | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: manager | ||
| env: | ||
| - name: RELATED_IMAGE_FEATURE_SERVER | ||
| value: ${FS_IMG} | ||
| - name: RELATED_IMAGE_CRON_JOB | ||
| value: ${CJ_IMG} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| - op: replace | ||
| path: "/spec/template/spec/containers/0/env/0" | ||
| value: | ||
| name: RELATED_IMAGE_FEATURE_SERVER | ||
| value: quay.io/feastdev/feature-server:0.62.0 | ||
| - op: replace | ||
| path: "/spec/template/spec/containers/0/env/1" | ||
| value: | ||
| name: RELATED_IMAGE_CRON_JOB | ||
| value: quay.io/openshift/origin-cli:4.17 | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| name: controller-manager | ||
| spec: | ||
| template: | ||
| spec: | ||
| containers: | ||
| - name: manager | ||
| env: | ||
| - name: RELATED_IMAGE_FEATURE_SERVER | ||
| value: quay.io/feastdev/feature-server:0.62.0 | ||
| - name: RELATED_IMAGE_CRON_JOB | ||
| value: quay.io/openshift/origin-cli:4.17 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -331,6 +331,7 @@ func (authz *FeastAuthorization) getLabels() map[string]string { | |
| return map[string]string{ | ||
| services.NameLabelKey: authz.Handler.FeatureStore.Name, | ||
| services.ServiceTypeLabelKey: string(services.AuthzFeastType), | ||
| services.ManagedByLabelKey: services.ManagedByLabelValue, | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality🟡 removeOrphanedRoles silently skips pre-upgrade custom auth Roles due to stricter label selector The authz.getLabels() function now includes ManagedByLabelKey (authz.go:334), and removeOrphanedRoles uses this label set as a list selector (authz.go:85). Pre-upgrade custom auth Roles only have {NameLabelKey, ServiceTypeLabelKey} without ManagedByLabelKey, so the API server's label selector will never match them. These orphaned Roles will never be cleaned up by removeOrphanedRoles. The main feast Role and RoleBinding are still cleaned up correctly via DeleteOwnedFeastObj (which looks up by name, not labels). Only custom auth roles from KubernetesAuthz.Roles are affected. The practical impact is limited: orphaned Roles have empty rules (no security impact) and have owner references for eventual GC on FeatureStore CR deletion. The window is narrow — it requires changing the Roles list concurrently with or very shortly after the operator upgrade, before the first reconciliation adds the label to existing Roles. Prompt for agentsIn authz.go, the removeOrphanedRoles function at line 81-101 lists Roles using authz.getLabels() as the label selector. Since getLabels() now includes ManagedByLabelKey, pre-upgrade Roles without this label are invisible to this cleanup function. To fix: either (a) use a separate label set for removeOrphanedRoles that omits ManagedByLabelKey (matching by NameLabelKey and ServiceTypeLabelKey only), or (b) run a one-time migration during reconciliation that adds ManagedByLabelKey to all existing authz Roles before removeOrphanedRoles is called. Was this helpful? React with 👍 or 👎 to provide feedback.
Sorry, something went wrong.
All reactions
|
||
| } | ||
| } | ||
|
|
||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.