feat: Add feature view versioning support to FAISS online store - #6256
Merged
ntkathole merged 1 commit intoApr 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
When enable_online_feature_view_versioning is enabled, FAISS indices are namespaced by versioned table keys (e.g. project_driver_stats_v2) so multiple feature view versions can coexist in memory. Reuses the shared compute_table_id() from helpers.py for consistency with PostgreSQL and MySQL stores. Signed-off-by: yassinnouh21 <yassinnouh21@gmail.com>
YassinNouh21
requested review from
dmartinol,
ejscribner and
tokoko
and removed request for
a team
April 10, 2026 10:24
YassinNouh21
requested review from
franciscojavierarceo and
ntkathole
and removed request for
dmartinol,
ejscribner and
tokoko
April 10, 2026 12:53
ntkathole
reviewed
Apr 11, 2026
Comment thread
sdk/python/feast/errors.py
| super().__init__( | ||
| f"Versioned feature reads (@v{version}) are not yet supported by {store_name}. " | ||
| f"Currently only SQLite, PostgreSQL, and MySQL support version-qualified feature references. " | ||
| f"Currently only SQLite, PostgreSQL, MySQL, and FAISS support version-qualified feature references. " |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
probbaly in future PRs we should get rid of this, it needs update everytime
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Why?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
to be less prone to error regarding that message being incorrect or outdated as new support being added
Sorry, something went wrong.
ntkathole
approved these changes
Apr 11, 2026
7 tasks
This was referenced Aug 18, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What this PR does / why we need it
Closes #6173
Feature view versioning was introduced in #6101, but version-qualified feature references (e.g. driver_stats@v2:trips_today) only worked with SQLite, PostgreSQL, and MySQL online stores. All other online stores raised VersionedOnlineReadNotSupported when a versioned ref was used.
This PR adds versioned read/write support to the FAISS online store, following the same pattern as the PostgreSQL/MySQL implementation (#6193):
Which issue(s) this PR fixes
Part of #2728
Checks
Testing Strategy
Added 16 unit tests covering _table_id with versioning disabled/enabled, projection.version_tag priority over current_version_number, version 0 edge case, versioned read support gate, versioned write/read round trips, namespace isolation between versions, missing index handling, and teardown cleanup.