FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(cli): Add `feast projects delete` command by mailtoboggavarapu-coder · Pull Request #6302 · feast-dev/feast · GitHub

/ feast Public

feat(cli): Add feast projects delete command - #6302

Closed
mailtoboggavarapu-coder wants to merge 2 commits into
feast-dev:masterfrom
mailtoboggavarapu-coder:feat/expose-project-delete-cli
ConversationCommits (2)ChecksFiles changed
Closed

feat(cli): Add feast projects delete command#6302
mailtoboggavarapu-coder wants to merge 2 commits into
feast-dev:masterfrom
mailtoboggavarapu-coder:feat/expose-project-delete-cli

Conversation

mailtoboggavarapu-coder commented Apr 20, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

Closes #5095

Exposes project deletion through the CLI by adding a new feast projects delete <name> subcommand to the existing projects group.

What's changed

Added project_delete command to sdk/python/feast/cli/projects.py:

Usage: feast projects delete [OPTIONS] NAME

  Delete a project and all its resources from the registry.

  This removes the project entry from the registry. Individual objects
  (feature views, entities, data sources) that belong to the project
  are also purged when commit=True (the default).

Options:
  -y, --yes  Skip confirmation prompt and delete immediately.
  --help     Show this message and exit.

Design notes

  • Uses store._registry.delete_project(name, commit=True) directly since FeatureStore does not yet expose a delete_project public method (the abstract method exists in BaseRegistry and is implemented in all concrete registries)
  • Adds an interactive confirmation prompt with click.confirm — can be skipped with --yes / -y for scripting
  • Raises SystemExit(1) on FeastObjectNotFoundException to match the pattern used by describe

Example

# Interactive (prompts for confirmation)
feast projects delete my-project

# Non-interactive
feast projects delete my-project --yes

Checklist

  • Added delete command to projects_cmd group
  • Confirmation prompt with --yes bypass flag
  • Error handling for non-existent projects
  • Follows existing CLI patterns in projects.py

mailtoboggavarapu-coder requested a review from a team as a code owner April 20, 2026 23:10

mailtoboggavarapu-coder commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Hi team! 👋

This adds the feast projects delete CLI command requested in #5095.

The implementation directly calls store._registry.delete_project() since the abstract method is already fully implemented in all concrete registries (SQL, file, GCS, etc.) — there just wasn't a CLI surface for it yet.

A few design choices I'd love feedback on:

  1. Confirmation prompt — I added an interactive click.confirm that can be bypassed with --yes/-y. Is this the right UX, or would you prefer a different safety mechanism?
  2. Registry access — I call store._registry.delete_project() directly since there's no public FeatureStore.delete_project() method yet. Happy to add a public wrapper on FeatureStore if that's preferred.

Would appreciate a review when you get a chance! Happy to adjust based on feedback. 🙏

This comment was marked as resolved.

Sign in to view

mailtoboggavarapu-coder commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the thorough review, @devin-ai-integration!

Fix applied in the latest commit:

  • Imported ProjectNotFoundException from feast.errors
  • Updated the except clause to catch both FeastObjectNotFoundException and ProjectNotFoundException, since registry implementations raise the latter when a project does not exist.

mailtoboggavarapu-coder commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi team! 👋 Friendly ping on this PR adding feast projects delete CLI command. Happy to address any feedback!

mailtoboggavarapu-coder commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi team! 👋 Friendly ping on this PR adding feast projects delete CLI command (issue #5095). Happy to address any feedback!

ntkathole changed the title feat(cli): add feast projects delete command feat(cli): Add feast projects delete command Apr 22, 2026

ntkathole commented Apr 22, 2026

Copy link
Copy Markdown
Member

@mailtoboggavarapu-coder please fix the linting pr checks

This comment was marked as resolved.

Sign in to view

mailtoboggavarapu-coder commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Hi team! Checking in on this PR adding the feast projects delete CLI command. The branch has been updated with the latest from master. Let me know if you'd like any changes!

feat(cli): add 'feast projects delete' command (issue feast-dev#5095)
686a55c 
Exposes project deletion via the CLI. The new `feast projects delete <name>`
command calls `store._registry.delete_project()` which is already implemented
in all concrete registries. Adds an interactive confirmation prompt that can
be bypassed with --yes/-y for scripted workflows.

- Adds type guard (`assert store._registry is not None`) for mypy.
- Catches both FeastObjectNotFoundException and ProjectNotFoundException so
  the CLI exits cleanly (exit code 1) for either variant raised by concrete
  registry implementations.

Squashed history: this commit consolidates the previous unsigned commits on
the branch into a single DCO-signed commit, per DCO requirements.

Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
mailtoboggavarapu-coder force-pushed the feat/expose-project-delete-cli branch from 544d892 to 686a55c Compare April 22, 2026 17:24

mailtoboggavarapu-coder commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Hi @ntkathole — thanks for the nudge! The PR checks have now been addressed:

  • DCO: The branch has been rebased onto the latest master and squashed into a single DCO-signed commit (Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>). DCO is now ✅ passing.
  • Lint / ruff: The projects.py changes pass ruff format --check and ruff check locally. The integration/unit-test lanes are currently gated skipped on this PR (path filters), but the code itself is formatter-clean.
  • mypy: The store._registry is not None guard was already added in the previous round to satisfy the union-attr error.

Ready for another look whenever you have time — thanks again!

fix: use store.registry property instead of store._registry in projec…
a8315f4 
…t_delete

store._registry is always None until accessed via the lazy-init registry
property. Using store._registry directly caused project_delete to always
crash with an AssertionError.

Fixes: Devin Review finding in feast-dev#6302
Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>

mailtoboggavarapu-coder commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the Devin review! Fixed the store._registry crash in the latest commit:

  • Removed the assert store._registry is not None guard (would always fail)
  • Changed store._registry.delete_project(...) → store.registry.delete_project(...) to use the lazy-init property

The registry property in feature_store.py handles initialization on first access, so this now works correctly.

mailtoboggavarapu-coder commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing this PR in favour of #6318 which has a clean single-commit history with a properly matched DCO sign-off (author name = Signed-off-by name). The DCO check was failing here because one commit had mailtoboggavarapu-coder as the git author name while the Signed-off-by said Venkateswarlu Boggavarapu. PR #6318 fixes this with a fresh single commit. All the same changes are included.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose project deletion to CLI

2 participants

Back | FazBrowse Home | New Git URL