fix: Add project filter to apply_data_source and delete_data_source - #6319
Closed
mailtoboggavarapu-coder wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ixes feast-dev#6206) apply_data_source and delete_data_source were not filtering by project, so operations on one project could affect data sources in other projects. Added project-based filtering to both methods to ensure project isolation. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>apply_data_source and delete_data_source were not filtering by project, so operations on one project could affect data sources in other projects. Added project-based filtering to both methods to ensure project isolation. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Regression tests for feast-dev#6206: verifies that apply_data_source and delete_data_source are properly project-scoped and do not affect data sources in other projects. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
This comment was marked as resolved.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the detailed review, @devin-ai-integration! Fixed both encoding corruptions in commit f3437b08:
Both arrow characters are now correct UTF-8. The em-dash on line 700 was already fixed in the previous commit (3bcaf45). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Superseded by PR #6322 which has all commits properly signed with Signed-off-by: (DCO ✅). The DCO failure here was caused by the encoding-fix commits and the "Update branch" merge commit lacking sign-offs. Closing in favor of #6322. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6206
apply_data_source and delete_data_source in registry.py were not filtering by project, meaning an operation on one project could silently overwrite or delete data sources with the same name in a different project.
What's changed
Tests
Added two regression tests in test_universal_registry.py: