FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Disable snowflake tests temporarily in CI by ntkathole · Pull Request #6356 · feast-dev/feast · GitHub

/ feast Public

fix: Disable snowflake tests temporarily in CI #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
May 1, 2026
+21 −9
Conversation 0 Commits 1 Checks 35 Files changed 3
Merged

fix: Disable snowflake tests temporarily in CI #6356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .baseline  (1) .py  (2) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 3 additions & 3 deletions .secrets.baseline
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1460,14 +1460,14 @@
"filename": "sdk/python/tests/universal/feature_repos/repo_configuration.py",
"hashed_secret": "d90e76ef629fb00c95f4e84fec29fbda111e2392",
"is_verified": false,
"line_number": 459
"line_number": 466
},
{
"type": "Secret Keyword",
"filename": "sdk/python/tests/universal/feature_repos/repo_configuration.py",
"hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
"is_verified": false,
"line_number": 461
"line_number": 468
}
],
"sdk/python/tests/universal/feature_repos/universal/data_sources/file.py": [
Expand Down Expand Up @@ -1539,5 +1539,5 @@
}
]
},
"generated_at": "2026-04-30T20:52:53Z"
"generated_at": "2026-05-01T07:12:24Z"
}
5 changes: 5 additions & 0 deletions sdk/python/tests/integration/materialization/test_snowflake.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
)
from tests.utils.e2e_test_validation import validate_offline_online_store_consistency

pytestmark = pytest.mark.skipif(
not os.getenv("SNOWFLAKE_CI_DEPLOYMENT"),
reason="Snowflake account not configured in CI (SNOWFLAKE_CI_DEPLOYMENT not set)",
)

SNOWFLAKE_ENGINE_CONFIG = {
"type": "snowflake.engine",
"account": os.getenv("SNOWFLAKE_CI_DEPLOYMENT", ""),
Expand Down
19 changes: 13 additions & 6 deletions sdk/python/tests/universal/feature_repos/repo_configuration.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -120,29 +120,36 @@
from tests.universal.feature_repos.universal.data_sources.redshift import (
RedshiftDataSourceCreator,
)
from tests.universal.feature_repos.universal.data_sources.snowflake import (
SnowflakeDataSourceCreator,
)

AVAILABLE_OFFLINE_STORES.extend(
[
("gcp", BigQueryDataSourceCreator),
("aws", RedshiftDataSourceCreator),
("aws", SnowflakeDataSourceCreator),
]
)

OFFLINE_STORE_TO_PROVIDER_CONFIG["bigquery"] = ("gcp", BigQueryDataSourceCreator)
OFFLINE_STORE_TO_PROVIDER_CONFIG["redshift"] = ("aws", RedshiftDataSourceCreator)
OFFLINE_STORE_TO_PROVIDER_CONFIG["snowflake"] = ("aws", SnowflakeDataSourceCreator)

AVAILABLE_ONLINE_STORES["redis"] = (REDIS_CONFIG, None)
AVAILABLE_ONLINE_STORES["dynamodb"] = (DYNAMO_CONFIG, None)
AVAILABLE_ONLINE_STORES["datastore"] = ("datastore", None)
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
AVAILABLE_ONLINE_STORES["bigtable"] = (BIGTABLE_CONFIG, None)
AVAILABLE_ONLINE_STORES["milvus"] = (MILVUS_CONFIG, None)

# Snowflake is disabled temporarily
if os.getenv("SNOWFLAKE_CI_DEPLOYMENT"):
from tests.universal.feature_repos.universal.data_sources.snowflake import (
SnowflakeDataSourceCreator,
)

AVAILABLE_OFFLINE_STORES.extend([("aws", SnowflakeDataSourceCreator)])
OFFLINE_STORE_TO_PROVIDER_CONFIG["snowflake"] = (
"aws",
SnowflakeDataSourceCreator,
)
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)


full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)
if full_repo_configs_module is not None:
Expand Down
Loading
Back | FazBrowse Home | New Git URL