fix: Eliminate TOCTOU race condition in Iceberg table registration

Signed-off-by: Abhishek Shinde <norizzabhii@gmail.com>
a52ea37feae72c9150534ae2e3ddb5cff7725a8f
commit a52ea37feae72c9150534ae2e3ddb5cff7725a8f
@@ -26,7 +26,6 @@
 from feast.infra.offline_stores.iceberg.catalog_manager import (
     create_feature_table,
     load_catalog,
-    table_exists,
     update_table_properties,
 )
 
@@ -107,35 +106,40 @@ def _register_single_feature_view(
     owner = fv.owner or ""
     tags = _build_tags(fv, project)
 
-    if table_exists(catalog, namespace, table_name):
-        update_table_properties(
+    try:
+        create_feature_table(
             catalog=catalog,
             namespace=namespace,
             table_name=table_name,
+            entity_columns=fv.entity_columns,
+            feature_columns=fv.features,
+            primary_keys=primary_keys,
+            timestamp_field=timestamp_field,
             description=description,
             owner=owner,
             project=project,
             tags=tags,
         )
         click.echo(
-            f"  ✓ Updated catalog table: {catalog_name}.{namespace}.{table_name}"
+            f"  ✓ Created catalog table: {catalog_name}.{namespace}.{table_name}"
         )
-    else:
-        create_feature_table(
+    except Exception as e:
+        from pyiceberg.exceptions import TableAlreadyExistsError
+
+        if not isinstance(e, TableAlreadyExistsError):
+            raise
+
+        update_table_properties(
             catalog=catalog,
             namespace=namespace,
             table_name=table_name,
-            entity_columns=fv.entity_columns,
-            feature_columns=fv.features,
-            primary_keys=primary_keys,
-            timestamp_field=timestamp_field,
             description=description,
             owner=owner,
             project=project,
             tags=tags,
         )
         click.echo(
-            f"  ✓ Created catalog table: {catalog_name}.{namespace}.{table_name}"
+            f"  ✓ Updated catalog table: {catalog_name}.{namespace}.{table_name}"
         )