FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Preinstall DuckDB delta extension for tests by larrysingleton007 · Pull Request #6744 · feast-dev/feast · GitHub

fix: Preinstall DuckDB delta extension for tests - #6744

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
larrysingleton007:fix/issue-6743-duckdb-delta-extension-race
Aug 18, 2026
Merged

fix: Preinstall DuckDB delta extension for tests#6744
ntkathole merged 1 commit into
feast-dev:masterfrom
larrysingleton007:fix/issue-6743-duckdb-delta-extension-race

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The DuckDB offline suite starts 8 pytest workers against a shared extension cache. On a fresh Linux runner, multiple workers can decide the delta extension is missing and race to install it. This has failed 3 unrelated CI runs with a DuckDB extension-file lock conflict.

This adds a serial Pixi task that installs delta before pytest starts. The existing test task depends on it, so workers only need to load the installed extension.

Which issue(s) this PR fixes:

Fixes #6743

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Ran the task from an empty DuckDB cache and confirmed Pixi completed install-delta-extension before starting pytest. A fresh connection reported delta as installed and not loaded. The complete 8-worker suite passed with 84 tests passed and 5 skipped.

Self-review

No issues found in the one-file task configuration change.

Misc

Please add kind/bug and ok-to-test.

codecov-commenter commented Aug 16, 2026
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.96%. Comparing base (602d752) to head (4805ed6).
⚠️ Report is 6 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6744      +/-   ##
==========================================
+ Coverage   46.91%   46.96%   +0.05%     
==========================================
  Files         416      416              
  Lines       50545    50606      +61     
  Branches     7252     7262      +10     
==========================================
+ Hits        23714    23768      +54     
- Misses      25157    25159       +2     
- Partials     1674     1679       +5     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 48.30% <ø> (+0.05%) ⬆️
see 6 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310ab51...4805ed6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Fixes feast-dev#6743

Signed-off-by: Larry Singleton <166439969+larrysingleton007@users.noreply.github.com>
ntkathole force-pushed the fix/issue-6743-duckdb-delta-extension-race branch from 91d7e74 to 4805ed6 Compare August 18, 2026 04:26
ntkathole merged commit fd4d49d into feast-dev:master Aug 18, 2026
17 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DuckDB delta extension install races across parallel tests

3 participants


Back | FazBrowse Home | New Git URL