feat: Add quality monitoring features for Trino offline store - #6779
Open
Marcus-Rosti wants to merge 1 commit into
Open
feat: Add quality monitoring features for Trino offline store#6779Marcus-Rosti wants to merge 1 commit into
Marcus-Rosti wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Marcus Rosti <rostimarcus@gmail.com>
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report❌ Patch coverage is 29.18288% with 182 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #6779 +/- ##
==========================================
- Coverage 47.09% 47.00% -0.09%
==========================================
Files 419 419
Lines 51878 52128 +250
Branches 7525 7569 +44
==========================================
+ Hits 24430 24501 +71
- Misses 25700 25874 +174
- Partials 1748 1753 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
it looks like the test times out unrelated to my changes? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Trino is missing the required endpoints for monitoring data quality... here I believe I've added most of them. I based it on the spark implementation. My familiarity with spark is pretty high -- trino less so.
Which issue(s) this PR fixes:
None?
Checks
Testing Strategy
Misc
I mainly copy and pasted the implementation from spark and then Gemini and I had a bit of fun refactoring that. I leveraged gemini pretty heavily to generate unit tests which I think are fairly exhaustive but I don't know y'all's vibes on that one.
oh the auth: Optional[...] = None is fix to another issue where excluding an auth implementation results in a pydantic error -- I just included that here selfishly