FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Initialize auth managers in standalone lineage server by ntkathole · Pull Request #6873 · feast-dev/feast · GitHub

  1. feast-dev
  2. feast

Repository navigation

fix: Initialize auth managers in standalone lineage server - #6873

Merged
jyejare merged 1 commit into
feast-dev:masterfrom
ntkathole:lineage_auth_wired
Oct 7, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: Initialize auth managers in standalone lineage server#6873
jyejare merged 1 commit into
feast-dev:masterfrom
ntkathole:lineage_auth_wired

Conversation

ntkathole commented Sep 26, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This PR aligns the standalone lineage server with the other Feast servers initializing
the Feast auth/security managers.

ntkathole self-assigned this Sep 26, 2026
ntkathole requested a review from a team as a code owner September 26, 2026 16:47

codecov-commenter commented Sep 26, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.32%. Comparing base (fcddb9c) to head (7dcc01f).

Files with missing lines Patch % Lines
sdk/python/feast/lineage_server.py 53.33% 6 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 

@@           Coverage Diff           @@
##           master    #6873   +/-   ##
=======================================
  Coverage   49.32%   49.32%           
=======================================
  Files         443      443           
  Lines       55080    55094   +14     
  Branches     8016     8017    +1     
=======================================
+ Hits        27167    27174    +7     
- Misses      26030    26036    +6     
- Partials     1883     1884    +1
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 50.71% <53.33%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
sdk/python/feast/lineage_server.py 40.39% <53.33%> (+0.98%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcddb9c...7dcc01f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ntkathole force-pushed the lineage_auth_wired branch 2 times, most recently from 85e2368 to 4fb3d36 Compare September 30, 2026 16:41
ntkathole requested a review from jyejare October 7, 2026 04:51
jyejare reviewed Oct 7, 2026
View reviewed changes

jyejare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This PR addresses an important security gap by propagating FeatureStore auth configuration into the standalone lineage server and initializing Feast’s auth managers before serving requests. The FastAPI integration is straightforward, and the added tests cover Kubernetes auth and the default auth configuration. One configuration edge case can leave the lineage server with an empty auth type, and the more complex OIDC path would benefit from focused regression coverage.

Comment thread infra/feast-operator/internal/controller/services/repo_config.go Outdated
Comment thread infra/feast-operator/internal/controller/services/repo_config_test.go
Comment thread infra/feast-operator/internal/controller/services/repo_config_test.go
Comment thread infra/feast-operator/internal/controller/services/repo_config.go Outdated
fix: Initialize auth managers in standalone lineage server
7dcc01f 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
ntkathole requested a review from jyejare October 7, 2026 13:25
jyejare merged commit ecd0d38 into feast-dev:master Oct 7, 2026
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jyejare jyejare approved these changes

Assignees

ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL