Repository navigation
fix: Make Milvus placeholder vectors valid on Milvus servers - #6881
Closed
simonhearne wants to merge 1 commit into
Closed
simonhearne wants to merge 1 commit into
simonhearne wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
5 of 7 tasks
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #6881 +/- ##
==========================================
+ Coverage 47.86% 47.87% +0.01%
==========================================
Files 422 422
Lines 52408 52414 +6
Branches 7607 7608 +1
==========================================
+ Hits 25084 25094 +10
+ Misses 25512 25509 -3
+ Partials 1812 1811 -1
Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Feature views without a vector field get a placeholder vector because Milvus requires one per collection. The placeholder was 1-dimensional, filled with NaN and left unindexed. Milvus Lite accepts all three, but Milvus servers and Zilliz Cloud reject dim < 2 and non-finite values, and refuse to load a collection with an unindexed vector field, so these feature views could not be created or read. The placeholder is now 2-dimensional, zero-filled and FLAT-indexed. Vector fields without vector_index=True also get a FLAT index so the collection can be loaded. Existing collections keep working because the placeholder is filled to the dimension recorded in the collection. Also fixes the Milvus docs page title and example config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Simon Hearne <simon.hearne@gmail.com>
simonhearne
force-pushed
the
fix/milvus-placeholder-vector
branch
from
c93b627 to
6b93ce9
Compare
September 28, 2026 14:34
Copy link
Copy Markdown
Member
|
merged second one |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Milvus needs a vector field in every collection, so feature views without one get a
_placeholder_vector. It was 1-dimensional, filled with NaN and not indexed. Milvus Lite accepts
all of that, but Milvus servers and Zilliz Cloud do not:
So feature views without vectors couldn't be used with a Milvus server. This PR:
collections with a 1-dim placeholder keep working;
Milvus 2.6.0 and Milvus Lite 3.2.1 both reject collections without a vector field
(schema does not contain vector field), so the placeholder can't be removed.
Which issue(s) this PR fixes:
N/A
Checks
Testing Strategy
Unit tests
Integration tests
Manual tests
Testing is not required for this change
Unit (Milvus Lite): round trip for a feature view without vectors.
Unit (mocked client): placeholder dim ≥ 2 and indexed; placeholder values match a legacy 1-dim collection.
Server: round trip for a feature view without vectors. Fails on master with the error above.
Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged.
Misc
Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus.
🤖 Generated with Claude Code