FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Pull the MinIO test image from pgsty/minio by patelchaitany · Pull Request #6919 · feast-dev/feast · GitHub

Repository navigation

fix: Pull the MinIO test image from pgsty/minio - #6919

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:fix/minio-test-image
Oct 1, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:fix/minio-test-image

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

MinIO no longer allows anonymous pulls from quay.io/minio/minio or docker.io/minio/minio. Every test that starts a MinIO container now fails at setup:

docker.errors.APIError: 500 Server Error for http+docker://localhost/v1.48/images/create?tag=RELEASE.2025-09-07T16-13-09Z&fromImage=quay.io%2Fminio%2Fminio: Internal Server Error ("unauthorized: access to the requested resource is not authorized")

This shows up as 13 [minio_registry] setup errors in integration-test-registration-local on every PR since about 2026-09-24. Docker Hub stopped serving the images around 2026-09-12, which is why #6838 moved to Quay. Quay then went private as well. MinIO stopped community image releases in October 2025 and archived minio/minio in December 2025.

This PR switches the three test references to pgsty/minio:RELEASE.2026-08-04T00-00-00Z:

  • It's a multi-arch (amd64 + arm64) build of the open-source MinIO server from PGSTY's community-maintained fork (pgsty/silo), licensed AGPLv3.
  • Its entrypoint, server /data command, MINIO_ROOT_USER/MINIO_ROOT_PASSWORD variables and /minio/health/live endpoint are unchanged, so testcontainers' MinioContainer needs no changes.

Files changed:

  • sdk/python/tests/integration/conftest.py (minio_server fixture)
  • sdk/python/tests/universal/feature_repos/universal/data_sources/file.py (DeltaS3FileSourceCreator, S3FileDataSourceCreator)
  • .secrets.baseline (line numbers shifted by the formatting change)

Which issue(s) this PR fixes:

Fixes the [minio_registry] setup errors in integration-test-registration-local.

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Ran tests/integration/registration/test_universal_registry.py -k minio_registry locally against this image: 11 passed. The other 2, test_modify_feature_views_success and test_apply_stream_feature_view_success, failed only because pyspark isn't installed locally. They fail the same way on the sqlite, local and mock-remote registries, and pass in CI.

Misc

Other options considered:

  • cgr.dev/chainguard/minio is free only as latest.
  • ghcr.io/coollabsio/minio has had no updates since 2025-10.
  • bitnamilegacy/minio is frozen, and its entrypoint wrapper conflicts with server /data.

quay.io/minio/minio and docker.io/minio/minio no longer allow anonymous
pulls, so every test that starts a MinIO container fails at setup with
"unauthorized: access to the requested resource is not authorized".

Switch the test fixtures to pgsty/minio:RELEASE.2026-08-04T00-00-00Z, a
multi-arch build of the open-source MinIO server from PGSTY's
community-maintained fork. It keeps the same entrypoint, MINIO_ROOT_*
variables and health endpoint, so testcontainers' MinioContainer works
unchanged.

Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
patelchaitany requested a review from a team as a code owner October 1, 2026 11:52

codecov-commenter commented Oct 1, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.50%. Comparing base (29af8c0) to head (32107be).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6919   +/-   ##
=======================================
  Coverage   48.50%   48.50%           
=======================================
  Files         427      427           
  Lines       53755    53755           
  Branches     7827     7827           
=======================================
  Hits        26076    26076           
  Misses      25813    25813           
  Partials     1866     1866           
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 49.87% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29af8c0...32107be. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ntkathole merged commit fe27230 into feast-dev:master Oct 1, 2026
37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL