Repository navigation
fix: Refresh the SQL registry cache after deleting a permission - #6953
Merged
ntkathole merged 1 commit intoOct 7, 2026
Merged
ntkathole merged 1 commit into
ntkathole merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
⚠️ Please install the Codecov Report❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #6953 +/- ##
==========================================
- Coverage 49.08% 49.01% -0.08%
==========================================
Files 433 435 +2
Lines 54332 54501 +169
Branches 7917 7947 +30
==========================================
+ Hits 26667 26711 +44
- Misses 25788 25917 +129
+ Partials 1877 1873 -4
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
ntkathole
force-pushed
the
fix/sql-registry-delete-permission-refresh
branch
from
d173693 to
0a3f4e9
Compare
October 7, 2026 04:41
ntkathole
approved these changes
Oct 7, 2026
delete_permission ran its own DELETE and returned, so unlike the other delete_* methods it never bumped the project's last-updated metadata or refreshed the cache in sync mode. list_permissions(allow_cache=True) kept returning the deleted permission. Route it through _delete_object like the other object types. That alone wasn't enough: _delete_object refreshed the cache inside the open write transaction, so the refresh read a snapshot that still contained the deleted row. Refresh after the transaction commits instead, matching _apply_object. This also fixes stale cached reads after delete_entity, delete_data_source and the other deletes that go through _delete_object. Signed-off-by: LuisFigueroaG <luis.h.figueroa.g@gmail.com>
ntkathole
force-pushed
the
fix/sql-registry-delete-permission-refresh
branch
from
0a3f4e9 to
6e19b21
Compare
October 7, 2026 05:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
SqlRegistry.delete_permission ran its own DELETE and returned, bypassing _delete_object. It therefore didn't update the project's last-updated metadata and didn't refresh the cache in sync mode, so list_permissions(allow_cache=True) kept returning the deleted permission.
Routing it through _delete_object (as the Snowflake registry already does) wasn't enough on its own: _delete_object called self.refresh() inside the open write transaction, so the cache was rebuilt from a snapshot that still contained the deleted row. delete_entity and the other deletes have the same problem on master; for example, list_entities(allow_cache=True) still returns a deleted entity. This moves the refresh after the transaction commits, which is what _apply_object already does.
Which issue(s) this PR fixes:
No existing issue.
Checks
Testing Strategy
Added test_delete_permission_refreshes_cache and test_delete_entity_refreshes_cache to test_sql_registry.py (sqlite registry, sync cache mode). The permission test also checks that a second delete still raises PermissionNotFoundException. Both fail on master and pass with this change. ruff and mypy pass on the changed files. The registry, permissions and local feature store unit tests pass, apart from two tests that need a Java runtime and fail the same way on master in my environment.