FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Publish the feast-mcp image on merge to master by patelchaitany · Pull Request #6962 · feast-dev/feast · GitHub

Repository navigation

ci: Publish the feast-mcp image on merge to master - #6962

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:ci/publish-feast-mcp-on-master
Oct 7, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
patelchaitany:ci/publish-feast-mcp-on-master

Conversation

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Follow-up to #6957, which added feast mcp and published its image from the
release workflow only. Master merges push feature-server,
feature-transformation-server and feast-operator to quay.io/feastdev-ci,
but not feast-mcp, so there is no :develop tag to test against between
releases.

This adds a build-feast-mcp-image job to master_only.yml that wraps the
feature-server image the matrix just pushed, tagging
quay.io/feastdev-ci/feast-mcp with the commit SHA and develop.

  • It runs after build-all-docker-images rather than as another matrix entry,
    because the base image it wraps has to exist first.
  • BASE_TAG is pinned to ${GITHUB_SHA}, not develop or latest, so
    feast-mcp:<sha> and feature-server:<sha> always come from the same tree.
  • The base here comes from Dockerfile.dev, which installs from the lockfiles
    and the working tree rather than PyPI, so this image carries mcp-server
    immediately — ahead of the first release that publishes the extra to PyPI.

Before merging

quay.io/feastdev-ci/feast-mcp does not exist yet and needs to be created as
a public repository, with the same robot write permissions as
feastdev-ci/feature-server. A push to a missing repository either fails
outright, or auto-creates a private repository that nobody can pull while CI
still reports success. The same applies to quay.io/feastdev/feast-mcp for the
release workflow already on master.

Which issue(s) this PR fixes:

N/A

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Verified the image builds and runs on both published architectures, using a
base built from Dockerfile.dev as this job does:

amd64 arm64
Build native, OpenShift native, Apple Silicon
platform.machine() x86_64 aarch64
GET /health {"status":"healthy","service":"mcp-server"} same

Misc

patelchaitany requested a review from a team as a code owner October 7, 2026 11:42
The release workflow builds feast-mcp, but master merges push
feature-server, feature-transformation-server and feast-operator to
quay.io/feastdev-ci without it, so there is no :develop tag to test with.

Add a job that wraps the feature-server image that job just pushed. It
needs that image present, so it runs after the matrix rather than inside
it. Unlike the release path this base comes from Dockerfile.dev, which
installs from the lockfiles and local source, so it carries mcp-server
before the first release that publishes it to PyPI.

Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
patelchaitany force-pushed the ci/publish-feast-mcp-on-master branch from f8a4e75 to f79b962 Compare October 7, 2026 11:49

codecov-commenter commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.32%. Comparing base (687bee8) to head (f79b962).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6962      +/-   ##
==========================================
+ Coverage   49.06%   49.32%   +0.25%     
==========================================
  Files         435      443       +8     
  Lines       54522    55080     +558     
  Branches     7954     8016      +62     
==========================================
+ Hits        26752    27167     +415     
- Misses      25892    26030     +138     
- Partials     1878     1883       +5     
Flag Coverage Δ
go-feature-server 30.58% <ø> (ø)
python-unit 50.71% <ø> (+0.26%) ⬆️
see 14 files with indirect coverage changes

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687bee8...f79b962. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ntkathole merged commit fcddb9c into feast-dev:master Oct 7, 2026
26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL