Add search to home page - #197
Conversation
Sorry, something went wrong.
|
+1 loving this |
Sorry, something went wrong.
|
This looks great! 🎉 I want to take some time to go over this because I think this is an important feature. Hold tight. |
Sorry, something went wrong.
colebemis
left a comment
There was a problem hiding this comment.
Just spent some time reviewing the code. Looks great!
I made some minor changes to the appearance of the search bar. Can you look over my changes and just give me a 👍 if you think it's ready to merge? 🎉
Sorry, something went wrong.
| @@ -0,0 +1,3 @@ | |||
| bell: notification | |||
| bell-off: notification-off | |||
| check: tick | |||
There was a problem hiding this comment.
I think eventually we'll want to keep this data somewhere else but this should be fine for now.
Sorry, something went wrong.
|
Looks good to me 👍 |
Sorry, something went wrong.
👋 Love this icon set. Thought I would have a go at adding search with basic tagging system to the home page as I find myself using the bowser page search on the website almost every time I need to use a new icon.
The search works off of listjs as I have seen suggested a few times in some issues. The tags are defined using a simple tags.yml file which is loaded using the Jekyl _data folder. Multiple tags can be defined for an icon by separating them with commas or spaces. You may want to bundle the tags into the feather library itself, however, I think it is fine to keep it as a feature of the website and keep the icons to their specific names.
#44
#45