fix(schema): Allow compound oneOf for queryProperty - #2545
Merged
daffl merged 1 commit intoJan 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Currently we use `anyOf` to create the `queryProperty` validations. This works fine until you nest it inside of another `oneOf`. In this case it fails every time. I've switched it to `anyOf` and have also added two tests to make sure it's working according to spec.
Copy link
Copy Markdown
Member
Author
|
Also, I should note that if we don't change to anyOf, the first test I added would fail. |
Sorry, something went wrong.
daffl
pushed a commit
that referenced
this pull request
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we use oneOf to create the queryProperty validations. This works fine until you nest it inside of another oneOf. In this case it fails every time. I've switched it to anyOf and have also added two tests to make sure it's both passing and failing correctly.