feat/Add X.com social link before Discord in docs navbar - #3636
Open
e-kibet wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thank you for the pull request. However, there is no official Feathers X account and the last account that was using the handle was a crypto scam so I'm a little hesitant to officially add it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@daffl thank you for checking the PR. In that case does it mean we need to create an official x account for feathersjs |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(If you have not already please refer to the contributing guideline as described
here)
Adds an X.com social icon/link to the docs navbar and places it before Discord.
No related issues.
No.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If this is a new feature, please remember to add the appropriate documentation in their respective pages in the docs folder.
Thanks for contributing to Feathers! ❤️