FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ci): align workflow Node.js version with package engines by MGPOCKY · Pull Request #3694 · feathersjs/feathers · GitHub

fix(ci): align workflow Node.js version with package engines - #3694

Open
MGPOCKY wants to merge 1 commit into
feathersjs:dovefrom
MGPOCKY:fix/ci-node-version-mismatch
Open

fix(ci): align workflow Node.js version with package engines#3694
MGPOCKY wants to merge 1 commit into
feathersjs:dovefrom
MGPOCKY:fix/ci-node-version-mismatch

Conversation

MGPOCKY commented Jul 31, 2026

Copy link
Copy Markdown

Why

Package metadata declares engines.node / volta.node / .nvmrc as 20,22,24,26, but CI workflows still pin node-version to a mismatched value.

That can make CI run on a runtime the project no longer supports (or skip the version the package actually targets).

What changed

Update the affected workflow node-version pins so they satisfy 20,22,24,26 (using 26 where a concrete pin is needed).

  • .github/workflows/update-dependencies.yml
    • node-version: '18.x' → node-version: '20.x'

Test plan

  • Package engines.node / volta.node / .nvmrc is still 20,22,24,26
  • Updated workflows now use versions consistent with that constraint
  • Relevant CI jobs on this branch look healthy

Found while auditing CI/package version consistency across popular repos.

MGPOCKY marked this pull request as ready for review July 31, 2026 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL