FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(typebox): support nested extension query keys by tonycoder-hub · Pull Request #3697 · feathersjs/feathers · GitHub

fix(typebox): support nested extension query keys - #3697

Closed
tonycoder-hub wants to merge 1 commit into
feathersjs:dovefrom
tonycoder-hub:fix/typebox-query-syntax-extension-sort
Closed

fix(typebox): support nested extension query keys#3697
tonycoder-hub wants to merge 1 commit into
feathersjs:dovefrom
tonycoder-hub:fix/typebox-query-syntax-extension-sort

Conversation

Copy link
Copy Markdown

Summary

  • Tell us about the problem your pull request is solving.

querySyntax currently accepts nested extension fields for property queries, but $sort and $select only expose top-level schema keys. As a result, valid nested extension keys such as profile.name are rejected. This change derives sortable/selectable nested keys from non-operator extension entries while continuing to exclude $-prefixed query operators.

  • Are there any open issues that are related to this?

Fixes #3526.

  • Is this PR dependent on PRs in other repos?

No.

Verification

  • npm run mocha --workspace @feathersjs/typebox (10 passing)
  • tsc -p packages/typebox/tsconfig.json --noEmit
  • git diff --check

Other Information

The implementation and review used AI assistance. The final diff, regression behavior, type checks, and test results were independently verified before submission.

tonycoder-hub force-pushed the fix/typebox-query-syntax-extension-sort branch from 608f7a4 to c028e7f Compare August 13, 2026 12:12

Copy link
Copy Markdown
Author

Closing as stale — opened on or before 2026-08-17 and still unmerged.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$sort from querySyntax function in @feathersjs/typebox does not consider the extensions param, so can't sort on extensions

1 participant


Back | FazBrowse Home | New Git URL