This pull request improves how query objects are merged, specifically by flattening nested $and branches so that $and never contains another $and. This makes the resulting queries simpler and avoids unnecessary nesting, which can help with readability and downstream processing. The changes include a new utility function, updates to the merge logic, and additional tests to verify the new behavior.
Improvements to query merging:
Added a new utility function flattenAndBranches in flatten-and-branches.ts that recursively hoists nested $and branches, ensuring that $and never contains another $and.
Updated mergeQueryBodies in merge-query-bodies.ts to use flattenAndBranches when merging with $and, so that merged queries are always flat with respect to $and. [1][2]
Testing and validation:
Added comprehensive unit tests for flattenAndBranches to verify its behavior with various nesting scenarios.
Added new test cases in merge-query-bodies.ts and merge-query.util.test.ts to ensure that merging queries with nested $and branches produces the expected flat structure. [1][2]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how query objects are merged, specifically by flattening nested $and branches so that $and never contains another $and. This makes the resulting queries simpler and avoids unnecessary nesting, which can help with readability and downstream processing. The changes include a new utility function, updates to the merge logic, and additional tests to verify the new behavior.
Improvements to query merging:
Testing and validation: