Support buttons at the root of a MenuBar. - #202
Draft
player-03 wants to merge 3 commits into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
In the unlikely event that this happens, the user probably wants it to be a clickable menu button, not an empty menu. If they really do want an empty menu, they can pass `[]`, as documented in all the hierarchical collections.
The previous implementation would trigger them for several incorrect reasons.
player-03
marked this pull request as draft
December 5, 2025 03:50
Copy link
Copy Markdown
Contributor
Author
|
I tried to make this work with keyboard controls, but MenuBar doesn't listen for key events unless a sub-menu is open. We could change that, but then we'd have to listen for focus events to know when to remove the stage keyboard listener, and that's a bunch of work for an edge case. Edit: And it doesn't highlight the button, we'd have to change how that works too. For now I'll keep this as a draft, in case someone comes up with a better idea. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the unlikely event that this happens, the user probably wants it to be a clickable menu button, not an empty menu. If they really do want an empty menu, they can pass [], as documented in all the hierarchical collections.