Skip anchored and derived features - #1052
Merged
rakeshkashyap123 merged 5 commits intoFeb 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
blee1234
reviewed
Feb 10, 2023
Comment thread
feathr-impl/src/main/scala/com/linkedin/feathr/offline/join/DataFrameFeatureJoiner.scala
Outdated
blee1234
previously approved these changes
Feb 10, 2023
blee1234
approved these changes
Feb 10, 2023
jaymo001
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous iteration (#1026) was adding a null column instead of skipping the feature completely. In this PR, we add the fix to completely skip the feature.