Code format with the right subfolders - #198
Merged
xiaoyongzhu merged 62 commits intoJun 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Add a screenshot for the new structure? |
Sorry, something went wrong.
hangfei
reviewed
Apr 30, 2022
Comment thread
feathr_project/test/test_pyduf_preprocessing_e2e.py
Outdated
Copy link
Copy Markdown
Collaborator
|
Could you provide a screenshot of the new py docs? |
Sorry, something went wrong.
This reverts commit c522450.
Copy link
Copy Markdown
Collaborator
|
Please test notebook as well since this changes a lot of structural stuff. |
Sorry, something went wrong.
hangfei
approved these changes
Jun 7, 2022
blrchen
approved these changes
Jun 7, 2022
Copy link
Copy Markdown
Member
Author
Good catch. I've verified this branch with the latest notebook and all those worked. |
Sorry, something went wrong.
This was referenced Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR is to add the right folder hierarchy for Feathr code (so that it can be better organized).
Other small improvements include:
pydocs in this PR: https://feathr-xiaoyzhu.readthedocs.io/en/latest/index.html
pydocs in main branch: https://feathr.readthedocs.io/
We should also move the api folder out from the python client. Waiting for @blrchen and @YihuiGuo to fix those as there seems to be some dependencies. It's described at #287.
This should have no end user impact as end users are using this:
from feathr import X
The new file structure is like this:
(base) xiazhu@xiazhu-mn1 feathr % tree feathr_project/feathr -I __pycache__ feathr_project/feathr ├── __init__.py ├── api │ ├── app │ │ ├── __init__.py │ │ ├── backends │ │ │ ├── backend_base.py │ │ │ └── purview_backend │ │ │ ├── __init__.py │ │ │ ├── purview_backend.py │ │ │ └── purview_backend_config.py │ │ ├── core │ │ │ ├── __init__.py │ │ │ ├── configs.py │ │ │ ├── error_code.py │ │ │ ├── error_handling.py │ │ │ ├── feathr_api_exception.py │ │ │ └── registry.py │ │ ├── main.py │ │ ├── models │ │ │ └── features.py │ │ └── routes │ │ ├── feature.py │ │ ├── job.py │ │ ├── offline_feature.py │ │ ├── online_feature.py │ │ ├── project.py │ │ └── transformation.py │ └── requirements.txt ├── client.py ├── constants.py ├── definition │ ├── _materialization_utils.py │ ├── aggregation.py │ ├── anchor.py │ ├── dtype.py │ ├── feathrconfig.py │ ├── feature.py │ ├── feature_derivations.py │ ├── lookup_feature.py │ ├── materialization_settings.py │ ├── query_feature_list.py │ ├── repo_definitions.py │ ├── settings.py │ ├── sink.py │ ├── source.py │ ├── transformation.py │ └── typed_key.py ├── exception ├── protobuf │ ├── __init__.py │ └── featureValue_pb2.py ├── registry │ ├── _feature_registry_purview.py │ └── feature_registry.py ├── secrets │ └── akv_client.py ├── spark_provider │ ├── _abc.py │ ├── _databricks_submission.py │ ├── _synapse_submission.py │ └── feathr_configurations.py ├── udf │ ├── _preprocessing_pyudf_manager.py │ └── feathr_pyspark_driver_template.py └── utils ├── _envvariableutil.py ├── _file_utils.py ├── feature_printer.py └── job_utils.py