FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Entity creation APIs by windoze · Pull Request #387 · feathr-ai/feathr · GitHub

Entity creation APIs - #387

Merged
windoze merged 8 commits into
mainfrom
windoze/sql-registry-create
Jun 27, 2022
Merged

Entity creation APIs#387
windoze merged 8 commits into
mainfrom
windoze/sql-registry-create

Conversation

windoze commented Jun 23, 2022

Copy link
Copy Markdown
Member

SQL registry now support entity creation.
Before this PR the SQL registry solely worked with UI without creating functions.

YihuiGuo previously approved these changes Jun 23, 2022

Yuqing-cat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a very important prerequisite PR for access control features. Very helpful enhancement.
I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it.
Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

Comment thread registry/sql-registry/main.py Outdated

windoze commented Jun 24, 2022

Copy link
Copy Markdown
Member Author

This is a very important prerequisite PR for access control features. Very helpful enhancement. I would suggest moving database.py to a common folder under /registry so that sql-based access control can reuse it. Also, are the interface.py and models.py a common description for all backend registries? If so, shall we move those common definition outside of sql-registry?

I plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Yuqing-cat previously approved these changes Jun 24, 2022

Copy link
Copy Markdown
Collaborator

plan to submit another following up PR for re-structuring, don't want to mess up before function stabilization.

Agree, I can also help to do this my access control PR.

YihuiGuo mentioned this pull request Jun 26, 2022
xiaoyongzhu deleted the windoze/sql-registry-create branch August 22, 2022 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL