PR for getting e2e deployment working [WIP] - #398
Merged
jainr merged 9 commits intoJul 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jainr
requested review from
Yuqing-cat,
blrchen,
edwincheung,
windoze and
xiaoyongzhu
June 25, 2022 14:44
xiaoyongzhu
approved these changes
Jun 27, 2022
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Yuqing-cat
approved these changes
Jun 27, 2022
Yuqing-cat
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
We could have a follow up PR to add some screenshot guide and FAQ for better deployment experience.
Sorry, something went wrong.
blrchen
reviewed
Jul 4, 2022
Comment thread
docs/how-to-guides/azure_resource_provision.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses following things to get the e2e deployment working after earlier PRs for individual pieces were merged.
TODO
SQL extension for bacpac import expects the storage account key to be passed even though the bacpac URL is a public blob, we need to brainstrom this and come up with another design.
Add Bacpac doc from @windoze after we decide on the approach to best address this.
Nice to have
Test whether AAD app could replace Service Principal ID. (not a blocker and could be addressed later on as an enhancement)