FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Access Control Plugin for Registry APIs by Yuqing-cat · Pull Request #409 · feathr-ai/feathr · GitHub

Access Control Plugin for Registry APIs - #409

Merged
Yuqing-cat merged 3 commits into
feathr-ai:mainfrom
Yuqing-cat:access-control
Jul 4, 2022
Merged

Access Control Plugin for Registry APIs#409
Yuqing-cat merged 3 commits into
feathr-ai:mainfrom
Yuqing-cat:access-control

Conversation

Copy link
Copy Markdown
Collaborator

This PR covers

  • A access control plugin for all registry APIs (regardless of registry type)
  • Access Control Management APIs and management UI
  • A readme document

Comment thread registry/api.py Outdated
Comment thread registry/Dockerfile Outdated
Comment thread registry/access_control/README.md Outdated

Copy link
Copy Markdown
Collaborator Author

Some updates:

  • Offer 2 options for @router.get("/features/{feature}":
    • if user pass project name, will validate access directly
    • if user do NOT pass project name, will validate access with the project name in feature response json
  • Clearer configuration
    • Add ".env" sample file
    • update os.envrion[""] to os.environ.get()
  • Add Exception for requests without token
  • The behavior of UI performs the same with test registry endpoint https://feathr-sql-registry.azurewebsites.net and localhost in all pages.

Will include in the following PR:

  • Add a redirect page for 403 Exceptions to tell user what access is required.

Comment thread registry/access_control/db_rbac.py Outdated
Comment thread registry/access_control/db_rbac.py Outdated
Comment thread registry/access_control/db_rbac.py Outdated
update sql query & enhance config

Copy link
Copy Markdown
Collaborator Author

Updates:

  • All SQL query is updated to prevent injection
  • All configs will follow the os.env >.env > default config sequence to get value.
  • All operation will read / write direct to SQL table rather than Cache.

Yuqing-cat added the safe to test Tag to execute build pipeline for a PR from forked repo label Jul 4, 2022
Yuqing-cat requested a review from blrchen July 4, 2022 07:43
Yuqing-cat merged commit f8b5de7 into feathr-ai:main Jul 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add azure ad authentication to Fast API Implement Basic RBAC Roles (Admin, Producer, Consumer)

3 participants


Back | FazBrowse Home | New Git URL