FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enhancing the deployment experience by jainr · Pull Request #443 · feathr-ai/feathr · GitHub

/ feathr Public

Enhancing the deployment experience - #443

Merged
jainr merged 14 commits into
feathr-ai:mainfrom
jainr:rijai/deploymentenhancement
Jul 12, 2022
ConversationCommits (14)ChecksFiles changed
Merged

Enhancing the deployment experience#443
jainr merged 14 commits into
feathr-ai:mainfrom
jainr:rijai/deploymentenhancement

Conversation

jainr commented Jul 7, 2022

Copy link
Copy Markdown
Collaborator
  1. Currently the user needs to pass the Principal Id as a pre-req, we now create a managed identity within the template.
  2. We also removed the bacpac URL paramter from UI, since that is something user should not need to worry about

Successful Deployment

jainr and others added 11 commits June 3, 2022 13:24
Adding EventHub creation to the deployment script
b8a5ce7
Merge branch 'linkedin:main' into main
c1ade5c
Upgrading API versions and fixing the if clause of KV property creati…
8d162f0 
…on for EH
Merge branch 'main' of github.com:jainr/feathr into main
c9bfe05
Merge branch 'main' of https://github.com/linkedin/feathr into main
1a6161f
Merge branch 'main' of https://github.com/linkedin/feathr into main
8d2de24
Merge branch 'main' of https://github.com/linkedin/feathr into main
e961b4d
Merge branch 'main' of https://github.com/linkedin/feathr into main
52b6181
Merge branch 'main' of https://github.com/linkedin/feathr into main
9079d91
Removing the need to ask for Principal Id from user and creating it i…
cb517f4 
…n the template. Also removing bacpac file url parameter, and copying it to user's storage account as part of the template. This simplifies the flow for user
Making template more organized and updated documentaton
ddb8245
jainr requested review from Yuqing-cat, windoze and xiaoyongzhu and removed request for windoze and xiaoyongzhu July 7, 2022 21:29
xiaoyongzhu previously approved these changes Jul 8, 2022
View reviewed changes
jainr requested review from blrchen and edwincheung July 9, 2022 04:38

blrchen commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator

Hello @jainr , I tried with this PR and the web app failed to start, could you please make following changes to make it align latest code

  1. Change name of app settings to following two, now UI and backend use different client id. These two are generated on the flying after ui app registration is completed, user does not need to provide
  • REACT_APP_AZURE_CLIENT_ID
  • REACT_APP_AZURE_TENANT_ID
  1. Change docker image name to feathrfeaturestore/feathr-registry. Now latest docker image supports selected registry scenario.

jainr commented Jul 11, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks Blair, I addressed your comments.

jainr merged commit 371444c into feathr-ai:main Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

edwincheung edwincheung approved these changes
Yuqing-cat Yuqing-cat approved these changes
xiaoyongzhu xiaoyongzhu left review comments
windoze Awaiting requested review from windoze
blrchen Awaiting requested review from blrchen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL