Various documentation fix - #477
Merged
xiaoyongzhu merged 29 commits intoAug 2, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
hangfei,
jainr and
jaymo001
July 19, 2022 13:49
Yuqing-cat
reviewed
Jul 19, 2022
Comment thread
docs/concepts/feathr-concepts-for-beginners.md
Outdated
Comment thread
docs/concepts/materializing-features.md
Outdated
Comment thread
feathr_project/feathr/definition/transformation.py
Outdated
Comment thread
docs/concepts/get-offline-features.md
blrchen
reviewed
Jul 20, 2022
Comment thread
docs/concepts/materializing-features.md
Copy link
Copy Markdown
Collaborator
The doc for get_offline_features uses product recommendation data but the doc for materilizate_features uses NYC taxi data. This might confuse readers. I know consolidate this mgiht not be intention of this PR am okay this be addressed in different PR. Refers to: docs/concepts/materializing-features.md:44 in 85a1c44. [](commit_id = 85a1c44, deletion_comment = False) |
Sorry, something went wrong.
blrchen
reviewed
Jul 20, 2022
Comment thread
docs/concepts/get-offline-features.md
Copy link
Copy Markdown
Member
Author
Yeah we need to update all the samples quite a bit so let's do it in a separate PR. |
Sorry, something went wrong.
Yuqing-cat
reviewed
Aug 1, 2022
Comment thread
docs/concepts/feathr-concepts-for-beginners.md
Outdated
Comment thread
feathr_project/feathr/utils/job_utils.py
Outdated
Comment thread
feathr_project/feathr/utils/job_utils.py
Outdated
blrchen
reviewed
Aug 1, 2022
Comment thread
docs/quickstart_databricks.md
Outdated
blrchen
reviewed
Aug 1, 2022
Comment thread
docs/quickstart_databricks.md
Outdated
blrchen
reviewed
Aug 1, 2022
Comment thread
feathr_project/feathr/utils/job_utils.py
Outdated
Yuqing-cat
previously approved these changes
Aug 1, 2022
Comment thread
feathr_project/feathr/utils/job_utils.py
Outdated
Yuqing-cat
approved these changes
Aug 2, 2022
Comment thread
feathr_project/test/test_azure_spark_e2e.py
blrchen
approved these changes
Aug 2, 2022
This was referenced Aug 2, 2022
Closed
Closed
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* Update README.md * update docs per feedback * Update feathr-concepts-for-beginners.md * Update feathr-concepts-for-beginners.md * update materialization setting doc * Update get-offline-features.md * Update get-offline-features.md * Update feathr-concepts-for-beginners.md * resolve comments * Update job_utils.py * fix typos * Update job_utils.py * Update client.py * format doc * Address comments * Update WriteToHDFSOutputProcessor.scala * Update WriteToHDFSOutputProcessor.scala * resolve comments * Resolve comments * fix test failures and typos * Update job_utils.py * fix comments and formats/typos * fix typos and test failures * update test names * Update test_fixture.py * Update test_fixture.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various documentation fix per feedback from end users, covering those issues:
#437
#464
#461
#473 (part of it)
This PR also rewrites the feature join doc, fixing various typos, and add csv support for get_result_df helper function per one of user's feedback.