Support 'enabled' configurations for offline stores - #545
Merged
blrchen merged 7 commits intoAug 24, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
blrchen
requested review from
Yuqing-cat,
blrchen,
hangfei,
windoze and
xiaoyongzhu
August 2, 2022 12:21
Copy link
Copy Markdown
Member
|
Quick comment - instead just return empty string, we should also eliminate the parameter names below: '--s3-config', self._get_s3_config_str(),
'--adls-config', self._get_adls_config_str(),
'--blob-config', self._get_blob_config_str(),
'--sql-config', self._get_sql_config_str(),
'--snowflake-config', self._get_snowflake_config_str()
i.e. if s3 is not configured, it doesn't make sense to have --s3-config in the param list |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
Modified the solution in new commit. |
Sorry, something went wrong.
jainr
self-requested a review
August 23, 2022 22:25
jainr
previously approved these changes
Aug 23, 2022
jainr
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks for the update, changes look good to me.
Sorry, something went wrong.
xiaoyongzhu
approved these changes
Aug 24, 2022
blrchen
approved these changes
Aug 24, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
For offline stores, S3/ADLS/WASB/JDBC/Snowflake, if any of its 'enabled' config variables are set to 'false' or undefined their other related environment variables will not be visited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For offline stores, S3/ADLS/WASB/JDBC/Snowflake, if any of its 'enabled' config variables are set to 'false' or undefined their other related environment variables will not be visited.