FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Extend Access Control Registry APIs to protect `post` ones by Yuqing-cat · Pull Request #551 · feathr-ai/feathr · GitHub

/ feathr Public

Extend Access Control Registry APIs to protect post ones - #551

Merged
Yuqing-cat merged 2 commits into
feathr-ai:mainfrom
Yuqing-cat:postapi
Aug 4, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Extend Access Control Registry APIs to protect post ones#551
Yuqing-cat merged 2 commits into
feathr-ai:mainfrom
Yuqing-cat:postapi

Conversation

Yuqing-cat commented Aug 3, 2022

Copy link
Copy Markdown
Collaborator

Included In This PR:

  1. post APIs validated in localhost
  • create project
  • create datasource
    The rest post APIs should have the similar behavior with create datasource.
  1. add global keyword protection and 400 exception class

This PR should be able to unblock the feathrclient sql issue with rbac registry endpoints.

Todo in follow up PRs:

  • Conduct more testing in both local and online deployments to confirm this feature.
  • Extract HttpExceptions into a seperate expection.py

Yuqing-cat added safe to test Tag to execute build pipeline for a PR from forked repo python code is mostly python labels Aug 3, 2022
Yuqing-cat requested review from jainr and windoze August 3, 2022 10:26
blrchen approved these changes Aug 4, 2022
View reviewed changes

blrchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yuqing-cat merged commit 755c1f0 into feathr-ai:main Aug 4, 2022
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
Extend Access Control Registry APIs to protect post ones (feathr-ai…
1330635 
…#551)

* Extend rbac registry APIs to post ones
* Update auth.py to support live.com CLI tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xiaoyongzhu xiaoyongzhu approved these changes
blrchen blrchen approved these changes
jainr Awaiting requested review from jainr
windoze Awaiting requested review from windoze

Assignees

No one assigned

Labels

python code is mostly python safe to test Tag to execute build pipeline for a PR from forked repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL