FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build docker image for feathr by YihuiGuo · Pull Request #554 · feathr-ai/feathr · GitHub

/ feathr Public

build docker image for feathr - #554

Merged
Yuqing-cat merged 2 commits into
feathr-ai:mainfrom
YihuiGuo:yihui/dockerize_feathr
Aug 23, 2022
ConversationCommits (2)ChecksFiles changed
Merged

build docker image for feathr#554
Yuqing-cat merged 2 commits into
feathr-ai:mainfrom
YihuiGuo:yihui/dockerize_feathr

Conversation

YihuiGuo commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

This PR builds a docker image with feathr installed, and vscode server / Jupyter lab integrated.

To build the docker image, navigate to feathr root folder ,

To start the docker, you need to specify the port mapping.
8080: vscode server
9090: jupyter lab

credential for jupyter lab and code server is "feathr"

jainr previously approved these changes Aug 8, 2022
View reviewed changes

jainr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, can you please add some documentation (with the screen shot you have in the PR description) under dev_guide explaining your motivation and steps to follow.

YihuiGuo commented Aug 8, 2022

Copy link
Copy Markdown
Contributor Author

Looks good to me, can you please add some documentation (with the screen shot you have in the PR description) under dev_guide explaining your motivation and steps to follow.

Sure, will update docs in this PR

YihuiGuo commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

@jainr I updated dev guide, pls help review, thx

YihuiGuo closed this Aug 9, 2022
YihuiGuo reopened this Aug 9, 2022

xiaoyongzhu commented Aug 9, 2022

Copy link
Copy Markdown
Member

@YihuiGuo thanks for the PR, can you elaborate on the use case there? Like when would users need this image?

windoze commented Aug 9, 2022

Copy link
Copy Markdown
Member

Which version of the Feathr client is integrated in this image? Can it be directly used in Jupyter notebook or users still need to install it by themselves?

YihuiGuo commented Aug 10, 2022

Copy link
Copy Markdown
Contributor Author

@YihuiGuo thanks for the PR, can you elaborate on the use case there? Like when would users need this image?

This image is built for feathr developers, make them able to create ephemeral and independent environment with feathr installed, and with powerful IDE ready to use.
For example, getting rid of all pre-defined and legacy environment variables, and run feathr tests in a "clean environment".

YihuiGuo commented Aug 10, 2022

Copy link
Copy Markdown
Contributor Author

Which version of the Feathr client is integrated in this image? Can it be directly used in Jupyter notebook or users still need to install it by themselves?

It is using latest version of feathr .
ref RUN pip install git+https://github.com/linkedin/feathr.git#subdirectory=feathr_project

Tested locally, feathr client can be directly used in notebook created by JupyterLab.

Yuqing-cat merged commit 4218542 into feathr-ai:main Aug 23, 2022
ahlag pushed a commit to ahlag/feathr that referenced this pull request Aug 26, 2022
build docker image for feathr (feathr-ai#554)
0bf2af4 
* build docker image for feathr
* Add docker guidance to dev guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

windoze windoze approved these changes
Yuqing-cat Yuqing-cat approved these changes
jainr jainr left review comments
blrchen Awaiting requested review from blrchen
edwincheung Awaiting requested review from edwincheung
hangfei Awaiting requested review from hangfei
xiaoyongzhu Awaiting requested review from xiaoyongzhu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL