Generic Input/Output of DataFrames, Client part - #580
Merged
xiaoyongzhu merged 19 commits intoAug 25, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
blrchen
reviewed
Aug 13, 2022
Comment thread
feathr_project/feathr/definition/sink.py
Outdated
blrchen
reviewed
Aug 13, 2022
Comment thread
feathr_project/feathr/definition/sink.py
Outdated
blrchen
previously approved these changes
Aug 15, 2022
Copy link
Copy Markdown
Collaborator
|
E2E test should get updated to cover write features to cosmos db |
Sorry, something went wrong.
xiaoyongzhu
reviewed
Aug 16, 2022
Comment thread
feathr_project/feathr/client.py
xiaoyongzhu
reviewed
Aug 16, 2022
Comment thread
feathr_project/feathr/client.py
Outdated
xiaoyongzhu
reviewed
Aug 16, 2022
Comment thread
feathr_project/feathr/definition/sink.py
xiaoyongzhu
reviewed
Aug 16, 2022
Comment thread
feathr_project/feathr/definition/source.py
Copy link
Copy Markdown
Collaborator
|
Can we add test cases to show this in working? |
Sorry, something went wrong.
jainr
requested review from
Yuqing-cat,
blrchen,
hangfei,
jainr,
jaymo001 and
xiaoyongzhu
August 23, 2022 22:23
blrchen
previously approved these changes
Aug 24, 2022
Yuqing-cat
previously approved these changes
Aug 24, 2022
xiaoyongzhu
reviewed
Aug 24, 2022
Comment thread
docs/how-to-guides/jdbc-cosmos-notes.md
xiaoyongzhu
reviewed
Aug 24, 2022
Comment thread
feathr_project/test/test_azure_spark_e2e.py
Outdated
xiaoyongzhu
reviewed
Aug 24, 2022
Comment thread
feathr_project/test/test_azure_spark_e2e.py
xiaoyongzhu
approved these changes
Aug 25, 2022
jainr
approved these changes
Aug 25, 2022
Copy link
Copy Markdown
Member
|
The test failures are irrelevant hence merging the code. |
Sorry, something went wrong.
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
* WIP * Remove ununsed import * Rename collection to container * Typo * Typo * Use Sink as offline store * Add CI test case * CI test fix * SQL and CosmosDb doc * CosmosDb test * Resolve comments * Resolve comments * Environment variables in upper case * Get env from secrets * Databricks env
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the client part corresponding to PR #475 , it contains Python code to generate config/jobparameters to enable the user to use CosmosDb as Data Source and Online/Offline storage.
It adds "CosmosDbSource" and "CosmosDbSink" in the client lib, the former is to use CosmosDb as data source, the latter is to use CosmosDb as online storage.
There are still some open questions about using CosmosDb as offline storage, the main one is, CosmosDb requires every row/doc to have a unique key, but in the feature joining job, we still don't know what should be used as a meaningful key.
For this reason, using CosmosDb as an offline store is not opened in the public interface, even the function is usable internally.