Remove extra dependencies to avoid dead loop of page re-rendering - #588
Merged
xiaoyongzhu merged 1 commit intoAug 17, 2022
Merged
Remove extra dependencies to avoid dead loop of page re-rendering#588xiaoyongzhu merged 1 commit into
xiaoyongzhu merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
blrchen
approved these changes
Aug 17, 2022
jainr
reviewed
Aug 17, 2022
jainr
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Not familiar with eslint but why are we disabling it?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
It requires us setting some variables as dependencies. Some of them are not necessary and can cause infinite page re-rending in a dead loop. So the console will keep printing that error message which may cause serious problem. |
Sorry, something went wrong.
xiaoyongzhu
approved these changes
Aug 17, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
…athr-ai#588) Co-authored-by: Enya-Yx <enya@Enyas-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How was this PR tested?
Does this PR introduce any user-facing changes?