Decode log error message - #602
Merged
blrchen merged 1 commit intoAug 24, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
xiaoyongzhu
approved these changes
Aug 24, 2022
Copy link
Copy Markdown
Member
|
maybe paste the error message in the pr description to make it clear for other approvers on why this need to be changed. |
Sorry, something went wrong.
xiaoyongzhu
requested review from
Yuqing-cat,
blrchen,
edwincheung,
hangfei,
jainr,
jaymo001 and
windoze
August 24, 2022 08:20
Copy link
Copy Markdown
Collaborator
Author
Thanks for the suggestion. Added some screenshot to show the difference. |
Sorry, something went wrong.
blrchen
approved these changes
Aug 24, 2022
ahlag
pushed a commit
to ahlag/feathr
that referenced
this pull request
Aug 26, 2022
Decode log error messages which begin with the char 'b' as the mark of byte string.s So that escape chars within messages can work well and can be printed out by a clear format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Before the change)
(After the change)
How was this PR tested?
Does this PR introduce any user-facing changes?