Replacing webapp-deploy action with workflow-webhook action. - #813
Merged
jainr merged 2 commits intoNov 2, 2022
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…hat calls the webhook URL of the deployed App Service
blrchen
approved these changes
Nov 2, 2022
Yuqing-cat
previously approved these changes
Nov 2, 2022
blrchen
previously approved these changes
Nov 2, 2022
… this version makes the webhook_secret optional
Yuqing-cat
approved these changes
Nov 2, 2022
blrchen
approved these changes
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current webapp-deploy action is mainly used when users need to push code to the webapp, it should ideally work for containers as well where it can directly call the webhook URL via the publish profile but that does not seem to work.
Replacing it instead with a simpler third party webhook action which just calls the webhook URL for App Service and that triggers the pull of latest sha for image tag from dockerhub.
https://github.com/distributhor/workflow-webhook
Resolves the issue we have with our internal demo environments not getting updated with nightly docker tags.
How was this PR tested?
tested it in my fork
https://github.com/jainr/feathr/actions/runs/3376143908
Does this PR introduce any user-facing changes?